* [PATCH 4/8] rename t/run.perl to xt/check-run
2023-09-18 10:15 6% [PATCH 0/8] portability odds and ends Eric Wong
@ 2023-09-18 10:15 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2023-09-18 10:15 UTC (permalink / raw)
To: meta
This allows us to get rid of some duplication in our Makefile
---
MANIFEST | 2 +-
Makefile.PL | 15 +++++++++------
t/nntpd.t | 2 +-
t/run.perl => xt/check-run.t | 4 ++--
4 files changed, 13 insertions(+), 10 deletions(-)
rename t/run.perl => xt/check-run.t (98%)
diff --git a/MANIFEST b/MANIFEST
index 2fe5dd17..7dba3836 100644
--- a/MANIFEST
+++ b/MANIFEST
@@ -577,7 +577,6 @@ t/reindex-time-range.t
t/rename_noreplace.t
t/replace.t
t/reply.t
-t/run.perl
t/search-amsg.eml
t/search-thr-index.t
t/search.t
@@ -621,6 +620,7 @@ t/xap_helper.t
t/xcpdb-reshard.t
version-gen.perl
xt/check-debris.t
+xt/check-run.t
xt/cmp-msgstr.t
xt/create-many-inboxes.t
xt/eml_check_limits.t
diff --git a/Makefile.PL b/Makefile.PL
index 97e00395..9dc18b5c 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -235,13 +235,16 @@ check-each :: pure_all
\$(EATMYDATA) \$(PROVE) --state=save -bvw -j\$(N)
-@\$(check_manifest)
-# this relies "--state=save" in check-each for best performance
-check-run :: pure_all check-man
- \$(EATMYDATA) \$(PROVE) -bvw t/run.perl :: -j\$(N)
- -@\$(check_manifest)
+# check-run relies "--state=save" in check-each for best performance
+check-run :: check-man
+
+# n.b. while `-' isn't specified as an allowed make(1posix) macro name,
+# GNU and *BSD both allow it.
+check-run_T_ARGS = -j\$(N)
-check-debris :: pure_all
- PERL5LIB="\$\$PWD"/blib/lib \$(PROVE) -bvw xt/\$@.t
+check-debris check-run :: pure_all
+ \$(EATMYDATA) \$(PROVE) -bvw xt/\$@.t :: \$(\$\@_T_ARGS)
+ -@\$(check_manifest)
check :: check-each
diff --git a/t/nntpd.t b/t/nntpd.t
index 9a7efd86..ffe0fd8c 100644
--- a/t/nntpd.t
+++ b/t/nntpd.t
@@ -330,7 +330,7 @@ Date: Fri, 02 Oct 1993 00:00:00 +0000
SKIP: {
if ($INC{'Search/Xapian.pm'} || $INC{'Xapian.pm'} &&
($ENV{TEST_RUN_MODE} // 2)) {
- skip 'Xapian.pm pre-loaded (by t/run.perl?)', 1;
+ skip 'Xapian.pm pre-loaded (by xt/check-run.t?)', 1;
}
$lsof or skip 'lsof missing', 1;
my @of = xqx([$lsof, '-p', $td->{pid}], undef, $noerr);
diff --git a/t/run.perl b/xt/check-run.t
similarity index 98%
rename from t/run.perl
rename to xt/check-run.t
index 9c8129d5..6eefcb7d 100755
--- a/t/run.perl
+++ b/xt/check-run.t
@@ -8,8 +8,8 @@
#
# *.t files run by this should not rely on global state.
#
-# Usage: $PERL -I lib -w t/run.perl -j4
-# Or via prove(1): prove -lvw t/run.perl :: -j4
+# Usage: $PERL -I lib -w xt/check-run.t -j4
+# Or via prove(1): prove -lvw xt/check-run.t :: -j4
use v5.12;
use IO::Handle; # ->autoflush
use PublicInbox::TestCommon;
^ permalink raw reply related [relevance 7%]
* [PATCH 0/8] portability odds and ends
@ 2023-09-18 10:15 6% Eric Wong
2023-09-18 10:15 7% ` [PATCH 4/8] rename t/run.perl to xt/check-run Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2023-09-18 10:15 UTC (permalink / raw)
To: meta
Nothing major, just a few things I noticed while working
on various *BSDs.
Eric Wong (8):
ci/run: favor `make check' as the default target
drop GNU nproc(1) support in favor of getconf(1)
ipc: assume SOCK_SEQPACKET exists
rename t/run.perl to xt/check-run
makefile: avoid needless use of double-colon rules
pop3d: split @FLOCK into $FLOCK_TMPL and @FLOCK_ORDER
install/deps: more fixes
makefile: avoid non-POSIX which(1)
Documentation/include.mk | 10 ++++++----
MANIFEST | 2 +-
Makefile.PL | 31 +++++++++++++++++--------------
ci/run.sh | 5 +++--
install/deps.perl | 17 ++++++++++++-----
lib/PublicInbox/IPC.pm | 22 +++++++++-------------
lib/PublicInbox/POP3D.pm | 16 ++++++++--------
t/nntpd.t | 2 +-
t/run.perl => xt/check-run.t | 4 ++--
9 files changed, 59 insertions(+), 50 deletions(-)
rename t/run.perl => xt/check-run.t (98%)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2023-09-18 10:15 6% [PATCH 0/8] portability odds and ends Eric Wong
2023-09-18 10:15 7% ` [PATCH 4/8] rename t/run.perl to xt/check-run Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).