* [PATCH 7/9] remove incorrect comment about strftime + locales
2017-01-07 1:44 6% [PATCH 0/9] misc cleanups and trimming Eric Wong
@ 2017-01-07 1:44 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2017-01-07 1:44 UTC (permalink / raw)
To: meta
We only need strftime to be locale-independent when generating
dates for email and HTTP headers. Purely numeric dates can
use strftime for ease-of-readability.
---
lib/PublicInbox/SearchMsg.pm | 2 +-
lib/PublicInbox/WwwAtomStream.pm | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/PublicInbox/SearchMsg.pm b/lib/PublicInbox/SearchMsg.pm
index 96406c6..4522eb6 100644
--- a/lib/PublicInbox/SearchMsg.pm
+++ b/lib/PublicInbox/SearchMsg.pm
@@ -69,7 +69,7 @@ sub subject ($) { __hdr($_[0], 'subject') }
sub to ($) { __hdr($_[0], 'to') }
sub cc ($) { __hdr($_[0], 'cc') }
-# no strftime, that is locale-dependent
+# no strftime, that is locale-dependent and not for RFC822
my @DoW = qw(Sun Mon Tue Wed Thu Fri Sat);
my @MoY = qw(Jan Feb Mar Apr May Jun Jul Aug Sep Oct Nov Dec);
diff --git a/lib/PublicInbox/WwwAtomStream.pm b/lib/PublicInbox/WwwAtomStream.pm
index a6817b3..5a10034 100644
--- a/lib/PublicInbox/WwwAtomStream.pm
+++ b/lib/PublicInbox/WwwAtomStream.pm
@@ -6,7 +6,6 @@ package PublicInbox::WwwAtomStream;
use strict;
use warnings;
-# FIXME: locale-independence:
use POSIX qw(strftime);
use Date::Parse qw(strptime);
use Digest::SHA qw(sha1_hex);
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/9] misc cleanups and trimming
@ 2017-01-07 1:44 6% Eric Wong
2017-01-07 1:44 7% ` [PATCH 7/9] remove incorrect comment about strftime + locales Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2017-01-07 1:44 UTC (permalink / raw)
To: meta
Weak reference dependencies are entirely gone. This should
simplify the internal object structures of Perl a bit and
hopefully make the data structures easier to reason about.
While we're at it, there's several search-related cleanups
to eliminate some dead code.
9 changes:
qspawn: prepare to support runtime reloading of Limiter
config: always use namespaced "publicinboxlimiter"
config: remove unused get() method
inbox: describe the full key name
inbox: eliminate weaken usage entirely
config: allow per-inbox nntpserver
remove incorrect comment about strftime + locales
searchmsg: favor direct hash access over accessor methods
search: remove subject_summary
lib/PublicInbox/Config.pm | 14 ++------
lib/PublicInbox/Inbox.pm | 73 ++++++++++++++++++----------------------
lib/PublicInbox/Qspawn.pm | 11 ++++--
lib/PublicInbox/Search.pm | 29 ++--------------
lib/PublicInbox/SearchIdx.pm | 4 +--
lib/PublicInbox/SearchMsg.pm | 36 +++-----------------
lib/PublicInbox/WwwAtomStream.pm | 1 -
t/config.t | 25 ++++++++++++--
t/config_limiter.t | 11 +++---
t/search.t | 17 ----------
10 files changed, 78 insertions(+), 143 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2017-01-07 1:44 6% [PATCH 0/9] misc cleanups and trimming Eric Wong
2017-01-07 1:44 7% ` [PATCH 7/9] remove incorrect comment about strftime + locales Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).