* Re: Troubleshooting threads missing from /all/
@ 2021-10-07 21:33 5% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-10-07 21:33 UTC (permalink / raw)
To: Konstantin Ryabitsev; +Cc: meta
Also, did you capture any error messages to stderr?
I suppose you would've told us if you did.
(resend, MTA dropped this part:)
In particular, I just posted a patch to fix
"Can't bless non-reference value" messages could've been causing
some messages to fail indexing completely.
<20211007082932.6985-1-e@80x24.org>
(overidx: each_by_mid: account for messages being deleted)
Error reporting/handling needs some work... :x
^ permalink raw reply [relevance 5%]
* [PATCH] overidx: each_by_mid: account for messages being deleted
@ 2021-10-07 8:29 7% Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-10-07 8:29 UTC (permalink / raw)
To: meta
This may fix some extindex problems and should get rid of
the "Can't bless non-reference value" errors.
---
lib/PublicInbox/OverIdx.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/OverIdx.pm b/lib/PublicInbox/OverIdx.pm
index 0c8a4d9ee3f8..985abbf4e693 100644
--- a/lib/PublicInbox/OverIdx.pm
+++ b/lib/PublicInbox/OverIdx.pm
@@ -158,7 +158,8 @@ SELECT $cols FROM over WHERE over.num = ? LIMIT 1
foreach (@$nums) {
$sth->execute($_->[0]);
- my $smsg = $sth->fetchrow_hashref;
+ # $cb may delete rows and invalidate nums
+ my $smsg = $sth->fetchrow_hashref // next;
$smsg = PublicInbox::Over::load_from_row($smsg);
$cb->($self, $smsg, @arg) or return;
}
^ permalink raw reply related [relevance 7%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-10-01 20:41 Troubleshooting threads missing from /all/ Eric Wong
2021-10-01 20:49 ` Konstantin Ryabitsev
2021-10-01 20:54 ` Eric Wong
2021-10-01 20:58 ` Konstantin Ryabitsev
2021-10-01 22:25 ` Eric Wong
2021-10-01 23:11 ` Konstantin Ryabitsev
2021-10-01 23:46 ` Eric Wong
2021-10-05 4:39 ` Eric Wong
2021-10-05 18:03 ` Konstantin Ryabitsev
2021-10-06 10:18 ` Eric Wong
2021-10-07 21:33 5% ` Eric Wong
2021-10-07 8:29 7% [PATCH] overidx: each_by_mid: account for messages being deleted Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).