* [PATCH 10/11] overidx: document column uses
2020-09-02 11:04 5% [PATCH 00/11] cleanups, mostly indexing related Eric Wong
@ 2020-09-02 11:04 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-09-02 11:04 UTC (permalink / raw)
To: meta
This may be useful for keeping our heads on straight dealing
with IMAP, NNTP, JMAP, etc.
---
lib/PublicInbox/OverIdx.pm | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/lib/PublicInbox/OverIdx.pm b/lib/PublicInbox/OverIdx.pm
index 6f0477f0..db4b7738 100644
--- a/lib/PublicInbox/OverIdx.pm
+++ b/lib/PublicInbox/OverIdx.pm
@@ -379,12 +379,12 @@ sub create_tables {
$dbh->do(<<'');
CREATE TABLE IF NOT EXISTS over (
- num INTEGER NOT NULL,
- tid INTEGER NOT NULL,
- sid INTEGER,
- ts INTEGER,
- ds INTEGER,
- ddd VARBINARY, /* doc-data-deflated */
+ num INTEGER NOT NULL, /* NNTP article number == IMAP UID */
+ tid INTEGER NOT NULL, /* THREADID (IMAP REFERENCES threading, JMAP) */
+ sid INTEGER, /* Subject ID (IMAP ORDEREDSUBJECT "threading") */
+ ts INTEGER, /* IMAP INTERNALDATE (Received: header, git commit time) */
+ ds INTEGER, /* RFC-2822 sent Date: header, git author time */
+ ddd VARBINARY, /* doc-data-deflated (->to_doc_data, ->load_from_data) */
UNIQUE (num)
)
@@ -406,13 +406,13 @@ CREATE TABLE IF NOT EXISTS counter (
$dbh->do(<<'');
CREATE TABLE IF NOT EXISTS subject (
sid INTEGER PRIMARY KEY AUTOINCREMENT,
- path VARCHAR(40) NOT NULL,
+ path VARCHAR(40) NOT NULL, /* SHA-1 of normalized subject */
UNIQUE (path)
)
$dbh->do(<<'');
CREATE TABLE IF NOT EXISTS id2num (
- id INTEGER NOT NULL,
+ id INTEGER NOT NULL, /* <=> msgid.id */
num INTEGER NOT NULL,
UNIQUE (id, num)
)
@@ -423,7 +423,7 @@ CREATE TABLE IF NOT EXISTS id2num (
$dbh->do(<<'');
CREATE TABLE IF NOT EXISTS msgid (
- id INTEGER PRIMARY KEY AUTOINCREMENT,
+ id INTEGER PRIMARY KEY AUTOINCREMENT, /* <=> id2num.id */
mid VARCHAR(244) NOT NULL,
UNIQUE (mid)
)
^ permalink raw reply related [relevance 7%]
* [PATCH 00/11] cleanups, mostly indexing related
@ 2020-09-02 11:04 5% Eric Wong
2020-09-02 11:04 7% ` [PATCH 10/11] overidx: document column uses Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-09-02 11:04 UTC (permalink / raw)
To: meta
Some cleanups ahead of detached index support.
Found some dead code, too.
Eric Wong (11):
msgmap: note how we use ->created_at
disambiguate OverIdx and Over by field name
use more idiomatic internal API for ->over access
search: remove special case for blank query
tests: add "use strict" and declare v5.10.1 compatibility
search: replace ->query with ->mset
search: remove {over_ro} field
imap: drop old, pre-Parse::RecDescent search parser
wwwaltid: drop unused sqlite3_missing function
overidx: document column uses
v2writable: reuse read-only shard counting code
lib/PublicInbox/ExtMsg.pm | 4 +-
lib/PublicInbox/IMAP.pm | 63 +----------------
lib/PublicInbox/Inbox.pm | 11 ++-
lib/PublicInbox/Mbox.pm | 6 +-
lib/PublicInbox/Msgmap.pm | 1 +
lib/PublicInbox/OverIdx.pm | 18 ++---
lib/PublicInbox/Search.pm | 32 ++++-----
lib/PublicInbox/SearchIdx.pm | 32 ++++-----
lib/PublicInbox/SearchView.pm | 3 +-
lib/PublicInbox/SolverGit.pm | 5 +-
lib/PublicInbox/V2Writable.pm | 59 ++++++----------
lib/PublicInbox/WwwAltId.pm | 16 +----
scripts/dupe-finder | 3 +-
t/altid.t | 8 +--
t/altid_v2.t | 7 +-
t/index-git-times.t | 17 +++--
t/indexlevels-mirror.t | 8 +--
t/mda_filter_rubylang.t | 6 +-
t/replace.t | 8 +--
t/search-thr-index.t | 8 +--
t/search.t | 126 +++++++++++++++++-----------------
t/v1reindex.t | 4 +-
t/v2mda.t | 16 +++--
t/v2mirror.t | 24 +++----
t/v2reindex.t | 9 +--
t/v2writable.t | 14 ++--
t/watch_filter_rubylang.t | 12 ++--
t/watch_maildir_v2.t | 30 ++++----
t/xcpdb-reshard.t | 3 +-
xt/eml_check_limits.t | 2 +
xt/perf-threading.t | 2 +-
31 files changed, 232 insertions(+), 325 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-09-02 11:04 5% [PATCH 00/11] cleanups, mostly indexing related Eric Wong
2020-09-02 11:04 7% ` [PATCH 10/11] overidx: document column uses Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).