* [PATCH 2/7] over: get_xref3: modify rows in-place
2022-08-04 8:16 5% [PATCH 0/7] various op/allocation golfing Eric Wong
@ 2022-08-04 8:16 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2022-08-04 8:16 UTC (permalink / raw)
To: meta
There's no need to create two intermediate arrays when we can
modify the existing arrayref.
---
lib/PublicInbox/Over.pm | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/PublicInbox/Over.pm b/lib/PublicInbox/Over.pm
index 786f9d92..d6409b2a 100644
--- a/lib/PublicInbox/Over.pm
+++ b/lib/PublicInbox/Over.pm
@@ -273,13 +273,13 @@ SELECT ibx_id,xnum,oidbin FROM xref3 WHERE docid = ? ORDER BY ibx_id,xnum ASC
my $eidx_key_sth = $dbh->prepare_cached(<<'', undef, 1);
SELECT eidx_key FROM inboxes WHERE ibx_id = ?
- [ map {
- my $r = $_;
+ for my $r (@$rows) {
$eidx_key_sth->execute($r->[0]);
my $eidx_key = $eidx_key_sth->fetchrow_array;
$eidx_key //= "missing://ibx_id=$r->[0]";
- "$eidx_key:$r->[1]:".unpack('H*', $r->[2]);
- } @$rows ];
+ $r = "$eidx_key:$r->[1]:".unpack('H*', $r->[2]);
+ }
+ $rows;
}
sub next_by_mid {
^ permalink raw reply related [relevance 7%]
* [PATCH 0/7] various op/allocation golfing
@ 2022-08-04 8:16 5% Eric Wong
2022-08-04 8:16 7% ` [PATCH 2/7] over: get_xref3: modify rows in-place Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2022-08-04 8:16 UTC (permalink / raw)
To: meta
Nothing major, but some of these reduce Perl internal pad space,
which tends to add up across codebases with many cold paths.
Eric Wong (7):
http: coerce SERVER_PORT to integer
over: get_xref3: modify rows in-place
isearch: mset_to_artnums: avoid unnecessary ops
lei_overview: remove pointless map {} op
imap: ensure_slices_exist: drop needless map and array
feed: avoid unnecessary map loop in non-over path
view: avoid intermediate array when streaming thread
lib/PublicInbox/Feed.pm | 13 ++++++-------
lib/PublicInbox/HTTP.pm | 2 +-
lib/PublicInbox/IMAP.pm | 7 ++-----
lib/PublicInbox/Isearch.pm | 5 ++---
lib/PublicInbox/LeiOverview.pm | 2 +-
lib/PublicInbox/Over.pm | 8 ++++----
lib/PublicInbox/View.pm | 4 ++--
7 files changed, 18 insertions(+), 23 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2022-08-04 8:16 5% [PATCH 0/7] various op/allocation golfing Eric Wong
2022-08-04 8:16 7% ` [PATCH 2/7] over: get_xref3: modify rows in-place Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).