* [PATCH 4/5] over*: use v5.10.1, drop warnings
2020-08-26 8:17 6% [PATCH 0/5] some minor SQLite-related cleanups Eric Wong
@ 2020-08-26 8:17 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-08-26 8:17 UTC (permalink / raw)
To: meta
v5.10.1 lets us use the lighter parent.pm instead of base.pm,
and we'll rely on the shebang to enable warnings (or not).
While we're in the area, drop a no-longer-necessary import for
PublicInbox::Search, since OverIdx doesn't require search.
---
lib/PublicInbox/Over.pm | 2 +-
lib/PublicInbox/OverIdx.pm | 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/lib/PublicInbox/Over.pm b/lib/PublicInbox/Over.pm
index 6b7d5216..0957cbdd 100644
--- a/lib/PublicInbox/Over.pm
+++ b/lib/PublicInbox/Over.pm
@@ -6,7 +6,7 @@
# tweaked/updated over time and rebuilt.
package PublicInbox::Over;
use strict;
-use warnings;
+use v5.10.1;
use DBI;
use DBD::SQLite;
use PublicInbox::Smsg;
diff --git a/lib/PublicInbox/OverIdx.pm b/lib/PublicInbox/OverIdx.pm
index 512c5f46..67f8cf65 100644
--- a/lib/PublicInbox/OverIdx.pm
+++ b/lib/PublicInbox/OverIdx.pm
@@ -9,14 +9,13 @@
# are denoted by a negative NNTP article number.
package PublicInbox::OverIdx;
use strict;
-use warnings;
-use base qw(PublicInbox::Over);
+use v5.10.1;
+use parent qw(PublicInbox::Over);
use IO::Handle;
use DBI qw(:sql_types); # SQL_BLOB
use PublicInbox::MID qw/id_compress mids_for_index references/;
use PublicInbox::Smsg qw(subject_normalized);
use Compress::Zlib qw(compress);
-use PublicInbox::Search;
use Carp qw(croak);
sub dbh_new {
^ permalink raw reply related [relevance 7%]
* [PATCH 0/5] some minor SQLite-related cleanups
@ 2020-08-26 8:17 6% Eric Wong
2020-08-26 8:17 7% ` [PATCH 4/5] over*: use v5.10.1, drop warnings Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-08-26 8:17 UTC (permalink / raw)
To: meta
Dropping some expensive dead code and avoiding some overloaded
method names to reduce confusion.
Eric Wong (5):
over: rename ->connect method to ->dbh
over: rename ->disconnect to ->dbh_close
over: recent: remove expensive COUNT query
over*: use v5.10.1, drop warnings
msgmap: use v5.10.1
lib/PublicInbox/Inbox.pm | 2 +-
lib/PublicInbox/Msgmap.pm | 3 ++-
lib/PublicInbox/Over.pm | 33 +++++++++++++--------------------
lib/PublicInbox/OverIdx.pm | 15 +++++++--------
lib/PublicInbox/V2Writable.pm | 4 ++--
lib/PublicInbox/Xapcmd.pm | 2 +-
scripts/dupe-finder | 2 +-
t/indexlevels-mirror.t | 29 +++++++++++++++--------------
t/over.t | 11 +++++------
t/search-thr-index.t | 4 ++--
t/v1reindex.t | 2 +-
t/v2reindex.t | 2 +-
t/v2writable.t | 4 +++-
t/watch_maildir_v2.t | 30 +++++++++++++++---------------
14 files changed, 69 insertions(+), 74 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-08-26 8:17 6% [PATCH 0/5] some minor SQLite-related cleanups Eric Wong
2020-08-26 8:17 7% ` [PATCH 4/5] over*: use v5.10.1, drop warnings Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).