user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH 2/6] nntp: simplify setting X-Alt-Message-ID
  2020-01-23 23:05  6% [PATCH 0/6] shorten and simplify uniq logic Eric Wong
@ 2020-01-23 23:05  7% ` Eric Wong
  0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-01-23 23:05 UTC (permalink / raw)
  To: meta

We can cut down on the number of operations required
using "grep" instead of "foreach".
---
 lib/PublicInbox/NNTP.pm | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index 35729f00..12f74c3d 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -423,10 +423,7 @@ sub set_nntp_headers ($$$$$) {
 		$hdr->header_set('Message-ID', $mid0);
 		my @alt = $hdr->header('X-Alt-Message-ID');
 		my %seen = map { $_ => 1 } (@alt, $mid0);
-		foreach my $m (@mids) {
-			next if $seen{$m}++;
-			push @alt, $m;
-		}
+		push(@alt, grep { !$seen{$_}++ } @mids);
 		$hdr->header_set('X-Alt-Message-ID', @alt);
 	}
 

^ permalink raw reply	[relevance 7%]

* [PATCH 0/6] shorten and simplify uniq logic
@ 2020-01-23 23:05  6% Eric Wong
  2020-01-23 23:05  7% ` [PATCH 2/6] nntp: simplify setting X-Alt-Message-ID Eric Wong
  0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-01-23 23:05 UTC (permalink / raw)
  To: meta

I noticed List::Util 1.45+ includes a new "uniq()" sub, but
that's only distributed with Perl as of 5.26+.

Since we care about supporting older versions of Perl, I still
took the opportunity to simplify some of our own similar logic
for making things unique.  It turns out only Inbox->nntp_url
really benefits from List::Util::uniq at the moment, but there's
some small simplifications to be had along the way.

Eric Wong (6):
  contentid: use map to generate %seen for Message-Ids
  nntp: simplify setting X-Alt-Message-ID
  inbox: simplify filtering for duplicate NNTP URLs
  mid: shorten uniq_mids logic
  wwwstream: shorten cloneurl uniquification
  contentid: ignore duplicate References: headers

 lib/PublicInbox/ContentId.pm | 12 ++++--------
 lib/PublicInbox/Inbox.pm     | 11 +++++------
 lib/PublicInbox/MID.pm       |  4 +---
 lib/PublicInbox/NNTP.pm      |  5 +----
 lib/PublicInbox/OverIdx.pm   |  3 +--
 lib/PublicInbox/WwwStream.pm |  8 +++-----
 6 files changed, 15 insertions(+), 28 deletions(-)

^ permalink raw reply	[relevance 6%]

Results 1-2 of 2 | reverse | sort options + mbox downloads above
-- links below jump to the message on this page --
2020-01-23 23:05  6% [PATCH 0/6] shorten and simplify uniq logic Eric Wong
2020-01-23 23:05  7% ` [PATCH 2/6] nntp: simplify setting X-Alt-Message-ID Eric Wong

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).