* [PATCH 1/2] nntp: remove DISABLED hash checks
2019-06-30 22:36 5% [PATCH 0/2] nntp: cleanup and support CAPABILITIES Eric Wong
@ 2019-06-30 22:36 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2019-06-30 22:36 UTC (permalink / raw)
To: meta
Before I figured out the long_response API, I figured there'd
be expensive, process-monopolizing commands which admins might
want to disable. Nearly 4 years later, we've never needed it
and running a server without commands such as OVER/XOVER is
unimaginable.
---
lib/PublicInbox/NNTP.pm | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index 26bc679f..57a67a50 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -32,9 +32,6 @@ my $OVERVIEW_FMT = join(":\r\n", @OVERVIEW, qw(Bytes Lines)) . ":\r\n";
my $LIST_HEADERS = join("\r\n", @OVERVIEW,
qw(:bytes :lines Xref To Cc)) . "\r\n";
-# disable commands with easy DoS potential:
-my %DISABLED; # = map { $_ => 1 } qw(xover list_overview_fmt newnews xhdr);
-
my $EXPMAP; # fd -> [ idle_time, $self ]
my $expt;
our $EXPTIME = 180; # 3 minutes
@@ -105,10 +102,9 @@ sub process_line ($$) {
my ($self, $l) = @_;
my ($req, @args) = split(/[ \t]/, $l);
return 1 unless defined($req); # skip blank line
- $req = lc($req);
$req = eval {
no strict 'refs';
- $req = $DISABLED{$req} ? undef : *{'cmd_'.$req}{CODE};
+ *{'cmd_'.lc($req)}{CODE};
};
return res($self, '500 command not recognized') unless $req;
return res($self, r501) unless args_ok($req, scalar @args);
@@ -187,7 +183,6 @@ sub cmd_list ($;$$) {
my $arg = shift @args;
$arg =~ tr/A-Z./a-z_/;
$arg = "list_$arg";
- return r501 if $DISABLED{$arg};
$arg = eval {
no strict 'refs';
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/2] nntp: cleanup and support CAPABILITIES
@ 2019-06-30 22:36 5% Eric Wong
2019-06-30 22:36 7% ` [PATCH 1/2] nntp: remove DISABLED hash checks Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2019-06-30 22:36 UTC (permalink / raw)
To: meta
I haven't noticed people using STARTTLS on public-inbox.org,
but I do notice CAPABILITIES being issued. Maybe clients
want to check it before trying STARTTLS?
This will also be required to advertise COMPRESS in the future.
Eric Wong (2):
nntp: remove DISABLED hash checks
nntp: add support for CAPABILITIES command
lib/PublicInbox/NNTP.pm | 26 ++++++++++++++++++++------
t/nntpd-tls.t | 18 ++++++++++++++++++
t/nntpd.t | 5 +++++
3 files changed, 43 insertions(+), 6 deletions(-)
--
EW
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-06-30 22:36 5% [PATCH 0/2] nntp: cleanup and support CAPABILITIES Eric Wong
2019-06-30 22:36 7% ` [PATCH 1/2] nntp: remove DISABLED hash checks Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).