* Re: interop with leafnode
@ 2019-05-05 21:40 6% ` Eric Wong
0 siblings, 0 replies; 6+ results
From: Eric Wong @ 2019-05-05 21:40 UTC (permalink / raw)
To: Dave Taht; +Cc: meta
Eric Wong <e@80x24.org> wrote:
> I guess there's some bug or missing commands in public-inbox-nntpd
> which leafnode relies on. Sorry I haven't had time to investigate
> or do much with public-inbox, lately (but maybe you could :)
I still haven't tried leafnode, but I just remembered I fixed an
NNTP bug a while back to give it compatibility with Alpine:
https://public-inbox.org/meta/20190116045802.ikm67b4cwigso3tc@dcvr/
commit d66aa534a4a7506cfc5cfab49d1e09f8db8be3dd
("nntp: header responses use CRLF consistently")
Perhaps it's the same bug you hit with leafnode?
^ permalink raw reply [relevance 6%]
* Re: [PATCH] nntp: header responses use CRLF consistently
2019-01-19 4:41 7% ` Konstantin Ryabitsev
@ 2019-01-19 4:47 7% ` Wang Kang
0 siblings, 0 replies; 6+ results
From: Wang Kang @ 2019-01-19 4:47 UTC (permalink / raw)
To: Konstantin Ryabitsev; +Cc: Eric Wong, meta, alpine-info
It works!
Love you guys!
--
Wang Kang
On Fri, 18 Jan 2019, Konstantin Ryabitsev wrote:
> On Sat, Jan 19, 2019 at 09:14:15AM +0800, Wang Kang wrote:
> > Dear Konstantin,
> >
> > The problem still exists. (Maybe a Perl 'restart' needed?)
>
> It was a bit weirder than that, but I got it sorted out. Try it now.
>
> -K
>
>
^ permalink raw reply [relevance 7%]
* Re: [PATCH] nntp: header responses use CRLF consistently
2019-01-19 1:14 7% ` Wang Kang
@ 2019-01-19 4:41 7% ` Konstantin Ryabitsev
2019-01-19 4:47 7% ` Wang Kang
0 siblings, 1 reply; 6+ results
From: Konstantin Ryabitsev @ 2019-01-19 4:41 UTC (permalink / raw)
To: Wang Kang; +Cc: Eric Wong, meta, alpine-info
On Sat, Jan 19, 2019 at 09:14:15AM +0800, Wang Kang wrote:
> Dear Konstantin,
>
> The problem still exists. (Maybe a Perl 'restart' needed?)
It was a bit weirder than that, but I got it sorted out. Try it now.
-K
^ permalink raw reply [relevance 7%]
* Re: [PATCH] nntp: header responses use CRLF consistently
2019-01-18 21:04 7% ` Konstantin Ryabitsev
@ 2019-01-19 1:14 7% ` Wang Kang
2019-01-19 4:41 7% ` Konstantin Ryabitsev
0 siblings, 1 reply; 6+ results
From: Wang Kang @ 2019-01-19 1:14 UTC (permalink / raw)
To: Konstantin Ryabitsev; +Cc: Eric Wong, meta, alpine-info
Dear Konstantin,
The problem still exists. (Maybe a Perl 'restart' needed?)
You can test it with:
alpine -url news://nntp.lore.kernel.org/org.kernel.vger.linux-btrfs
The already fixed one:
alpine -url news://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
Remember to press enter on one of the message to see the content, that's
when it will stall.
Thank you.
--
Wang Kang
On Fri, 18 Jan 2019, Konstantin Ryabitsev wrote:
> On Wed, Jan 16, 2019 at 04:58:02AM +0000, Eric Wong wrote:
> > Thanks, I'm pretty sure the following will fix it.
> >
> > Not sure why others hadn't noticed since there's a lot of Alpine
> > users judging from Message-IDs. Anyways I managed to replicate it
> > quickly with alpine in Debian ("alpine -url news://...") and
> > strace quickly showed me the difference.
> >
> > Deploying to news.public-inbox.org shortly.
> > Cc-ing Konstantin for kernel.org.
>
> The latest master now runs on lore.kernel.org, so this problem should be
> fixed there as well.
>
> Best,
> -K
>
^ permalink raw reply [relevance 7%]
* Re: [PATCH] nntp: header responses use CRLF consistently
2019-01-16 4:58 14% ` [PATCH] nntp: header responses use CRLF consistently Eric Wong
@ 2019-01-18 21:04 7% ` Konstantin Ryabitsev
2019-01-19 1:14 7% ` Wang Kang
0 siblings, 1 reply; 6+ results
From: Konstantin Ryabitsev @ 2019-01-18 21:04 UTC (permalink / raw)
To: Eric Wong; +Cc: Wang Kang, meta, alpine-info
On Wed, Jan 16, 2019 at 04:58:02AM +0000, Eric Wong wrote:
> Thanks, I'm pretty sure the following will fix it.
>
> Not sure why others hadn't noticed since there's a lot of Alpine
> users judging from Message-IDs. Anyways I managed to replicate it
> quickly with alpine in Debian ("alpine -url news://...") and
> strace quickly showed me the difference.
>
> Deploying to news.public-inbox.org shortly.
> Cc-ing Konstantin for kernel.org.
The latest master now runs on lore.kernel.org, so this problem should be
fixed there as well.
Best,
-K
^ permalink raw reply [relevance 7%]
* [PATCH] nntp: header responses use CRLF consistently
@ 2019-01-16 4:58 14% ` Eric Wong
2019-01-18 21:04 7% ` Konstantin Ryabitsev
0 siblings, 1 reply; 6+ results
From: Eric Wong @ 2019-01-16 4:58 UTC (permalink / raw)
To: Wang Kang; +Cc: meta, alpine-info, Konstantin Ryabitsev
Thanks, I'm pretty sure the following will fix it.
Not sure why others hadn't noticed since there's a lot of Alpine
users judging from Message-IDs. Anyways I managed to replicate it
quickly with alpine in Debian ("alpine -url news://...") and
strace quickly showed me the difference.
Deploying to news.public-inbox.org shortly.
Cc-ing Konstantin for kernel.org.
---------------8<-----------------
Subject: [PATCH] nntp: header responses use CRLF consistently
Alpine is apparently stricter than other clients I've tried
w.r.t. using CRLF for headers. So do the same thing we do for
bodies to ensure we only emit CRLFs and no bare LFs.
Reported-by: Wang Kang <i@scateu.me>
https://public-inbox.org/meta/alpine.DEB.2.21.99.1901161043430.29788@la.scateu.me/
---
lib/PublicInbox/NNTP.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index 623ffd3..63d5870 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -515,6 +515,7 @@ sub set_art {
sub _header ($) {
my $hdr = $_[0]->header_obj->as_string;
utf8::encode($hdr);
+ $hdr =~ s/(?<!\r)\n/\r\n/sg;
$hdr
}
--
EW
^ permalink raw reply related [relevance 14%]
Results 1-6 of 6 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2018-10-17 16:28 interop with leafnode Dave Taht
2018-10-27 0:10 ` Eric Wong
2019-05-05 21:40 6% ` Eric Wong
2019-01-16 2:54 NNTP served by public-inbox stalled in Alpine 2.21.99 Wang Kang
2019-01-16 4:58 14% ` [PATCH] nntp: header responses use CRLF consistently Eric Wong
2019-01-18 21:04 7% ` Konstantin Ryabitsev
2019-01-19 1:14 7% ` Wang Kang
2019-01-19 4:41 7% ` Konstantin Ryabitsev
2019-01-19 4:47 7% ` Wang Kang
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).