* [PATCH] nntp: clear local timer on idle client expiry
@ 2019-07-12 1:58 7% Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2019-07-12 1:58 UTC (permalink / raw)
To: meta
We need to ensure further timers can be registered if there's
currently no idle clients.
---
lib/PublicInbox/NNTP.pm | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index f4208f87..0d2bc4f3 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -57,22 +57,20 @@ sub expire_old () {
my $now = now();
my $exp = $EXPTIME;
my $old = $now - $exp;
- my $nr = 0;
my %new;
while (my ($fd, $v) = each %$EXPMAP) {
my ($idle_time, $nntp) = @$v;
if ($idle_time < $old) {
if (!$nntp->shutdn) {
- ++$nr;
$new{$fd} = $v;
}
} else {
- ++$nr;
$new{$fd} = $v;
}
}
$EXPMAP = \%new;
- $expt = PublicInbox::EvCleanup::later(*expire_old) if $nr;
+ $expt = scalar(keys %new) ? PublicInbox::EvCleanup::later(*expire_old)
+ : undef;
}
sub greet ($) { $_[0]->write($_[0]->{nntpd}->{greet}) };
--
EW
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-07-12 1:58 7% [PATCH] nntp: clear local timer on idle client expiry Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).