user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH] nntp: allow multiple spaces or tabs to delimit args
@ 2020-04-02  0:17  7% Eric Wong
  0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2020-04-02  0:17 UTC (permalink / raw)
  To: meta

While this is not a known problem in practice,
RFC 3977 section 3.1 states:

	Keywords and arguments MUST each be separated by one
	or more space or TAB characters.
---
 lib/PublicInbox/NNTP.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index 277657e6..66de41ad 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -76,7 +76,7 @@ sub args_ok ($$) {
 # returns 1 if we can continue, 0 if not due to buffered writes or disconnect
 sub process_line ($$) {
 	my ($self, $l) = @_;
-	my ($req, @args) = split(/[ \t]/, $l);
+	my ($req, @args) = split(/[ \t]+/, $l);
 	return 1 unless defined($req); # skip blank line
 	$req = $self->can('cmd_'.lc($req));
 	return res($self, '500 command not recognized') unless $req;

^ permalink raw reply related	[relevance 7%]

Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-04-02  0:17  7% [PATCH] nntp: allow multiple spaces or tabs to delimit args Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).