* [PATCH 6/9] msgmap: share most of check_inodes w/ over
2021-10-12 11:46 5% [PATCH 0/9] various read-only daemon and WWW things Eric Wong
@ 2021-10-12 11:47 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-10-12 11:47 UTC (permalink / raw)
To: meta
We still need to account for msgmap being open all the time
and not having separate read-only vs. read-write packages.
---
lib/PublicInbox/Msgmap.pm | 19 ++++---------------
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/lib/PublicInbox/Msgmap.pm b/lib/PublicInbox/Msgmap.pm
index de9fd989..978730e2 100644
--- a/lib/PublicInbox/Msgmap.pm
+++ b/lib/PublicInbox/Msgmap.pm
@@ -257,21 +257,10 @@ sub skip_artnum {
sub check_inodes {
my ($self) = @_;
- # no filename if in-:memory:
- my $f = $self->{dbh}->sqlite_db_filename // return;
- if (my @st = stat($f)) { # did st_dev, st_ino change?
- my $st = pack('dd', $st[0], $st[1]);
- if ($st ne ($self->{st} // $st)) {
- my $tmp = eval { ref($self)->new_file($f) };
- if ($@) {
- warn "E: DBI->connect($f): $@\n";
- } else {
- %$self = %$tmp;
- }
- }
- } else {
- warn "W: stat $f: $!\n";
- }
+ $self->{dbh} // return;
+ my $rw = !$self->{dbh}->{ReadOnly};
+ PublicInbox::Over::check_inodes($self);
+ $self->{dbh} //= PublicInbox::Over::dbh_new($self, !$rw);
}
1;
^ permalink raw reply related [relevance 7%]
* [PATCH 0/9] various read-only daemon and WWW things
@ 2021-10-12 11:46 5% Eric Wong
2021-10-12 11:47 7% ` [PATCH 6/9] msgmap: share most of check_inodes w/ over Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-10-12 11:46 UTC (permalink / raw)
To: meta
Read-only daemons close idle descriptors much more aggressively,
now. This should reduce userspace and kernel memory use during
non-peak times with negligible slowdown under heavy load.
Some fairly big msgmap-related cleanups and WWW now exposes
mm->created_at AKA UIDVALIDITY as the Last-Modified time
of the _/text/config/raw endpoint. (see 9/9)
Eric Wong (9):
daemon: use v5.10.1, disable local warnings
daemon: quiet down Eml-related warnings
search: delete QueryParser along with DB handle
nntp: use defined-OR from Perl 5.10 for msgid check
msgmap: use DBI->prepare_cached
msgmap: share most of check_inodes w/ over
daemon: unconditionally close Xapian shards on cleanup
msgmap: ->new_file to supports $ibx arg, drop ->new
www: _/text/config/raw Last-Modified: is mm->created_at
lib/PublicInbox/Daemon.pm | 8 ++-
lib/PublicInbox/Inbox.pm | 18 +++---
lib/PublicInbox/InboxWritable.pm | 2 +-
lib/PublicInbox/LeiMirror.pm | 13 ++--
lib/PublicInbox/Msgmap.pm | 102 +++++++++++++------------------
lib/PublicInbox/NNTP.pm | 6 +-
lib/PublicInbox/Search.pm | 14 -----
lib/PublicInbox/SearchIdx.pm | 3 +-
lib/PublicInbox/V2Writable.pm | 4 +-
lib/PublicInbox/WwwText.pm | 3 +
t/altid.t | 4 +-
t/altid_v2.t | 4 +-
t/extsearch.t | 10 +--
t/filter_rubylang.t | 2 +-
t/init.t | 3 +-
t/lei-mirror.t | 31 +++++++++-
t/msgmap.t | 5 +-
t/psgi_v2.t | 10 ++-
18 files changed, 120 insertions(+), 122 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-10-12 11:46 5% [PATCH 0/9] various read-only daemon and WWW things Eric Wong
2021-10-12 11:47 7% ` [PATCH 6/9] msgmap: share most of check_inodes w/ over Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).