user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH] mda: export @BAD_HEADERS variable
@ 2016-05-01  9:00  7% Eric Wong
  0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2016-05-01  9:00 UTC (permalink / raw)
  To: meta

This should allow users to change and add headers as needed.
While we're at it, add the X-Original-To header Postfix likes
to add; it seems like pointless bloat with the existence of
(important) Received: headers.
---
 lib/PublicInbox/MDA.pm | 25 ++++++++++++++-----------
 1 file changed, 14 insertions(+), 11 deletions(-)

diff --git a/lib/PublicInbox/MDA.pm b/lib/PublicInbox/MDA.pm
index b147102..e1207b5 100644
--- a/lib/PublicInbox/MDA.pm
+++ b/lib/PublicInbox/MDA.pm
@@ -11,6 +11,19 @@ use Date::Parse qw(strptime);
 use constant MAX_SIZE => 1024 * 500; # same as spamc default, should be tunable
 use constant MAX_MID_SIZE => 244; # max term size - 1 in Xapian
 
+our @BAD_HEADERS = (
+	# postfix
+	qw(delivered-to x-original-to), # prevent training loops
+
+	# The rest are taken from Mailman 2.1.15:
+	# could contain passwords:
+	qw(approved approve x-approved x-approve urgent),
+	# could be used phishing:
+	qw(return-receipt-to disposition-notification-to x-confirm-reading-to),
+	# Pegasus mail:
+	qw(x-pmrqc)
+);
+
 # drop plus addressing for matching
 sub __drop_plus {
 	my ($str_addr) = @_;
@@ -70,17 +83,7 @@ sub set_list_headers {
 		$simple->header_set("List-Id", "<$pa>"); # RFC2919
 	}
 
-	foreach my $h (qw(delivered-to), # prevent training loops
-			# The rest are taken from Mailman 2.1.15
-			# could contain passwords:
-			qw(approved approve x-approved x-approve urgent),
-			# could be used phishing:
-			qw(return-receipt-to disposition-notification-to
-			   x-confirm-reading-to),
-			# Pegasus mail:
-			qw(x-pmrqc)) {
-		$simple->header_set($h);
-	}
+	$simple->header_set($_) foreach @BAD_HEADERS;
 }
 
 1;
-- 
EW


^ permalink raw reply related	[relevance 7%]

Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-05-01  9:00  7% [PATCH] mda: export @BAD_HEADERS variable Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).