* [PATCH 2/2] mboxgz: ensure gzipped mboxes always have filenames
2020-01-30 9:19 5% [PATCH 0/2] subject-free tests and updates Eric Wong
@ 2020-01-30 9:19 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-01-30 9:19 UTC (permalink / raw)
To: meta
Lets always have Content-Disposition for files intended
to be downloaded for consumption by non-browsers, such
as pigz, zcat, "git am".
This is also to be consistent with the non-gzipped mbox
$MESSAGE_ID/raw endpoint.
---
lib/PublicInbox/MboxGz.pm | 10 ++++------
t/psgi_search.t | 6 ++++++
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/lib/PublicInbox/MboxGz.pm b/lib/PublicInbox/MboxGz.pm
index 08e3c846..30074e4d 100644
--- a/lib/PublicInbox/MboxGz.pm
+++ b/lib/PublicInbox/MboxGz.pm
@@ -21,12 +21,10 @@ sub response {
my ($class, $ctx, $cb, $fn) = @_;
my $body = $class->new($ctx, $cb);
# http://www.iana.org/assignments/media-types/application/gzip
- my @h = qw(Content-Type application/gzip);
- if (defined $fn && $fn ne '') {
- $fn = to_filename($fn);
- push @h, 'Content-Disposition', "inline; filename=$fn.mbox.gz";
- }
- [ 200, \@h, $body ];
+ $fn = defined($fn) && $fn ne '' ? to_filename($fn) : 'no-subject';
+ my $h = [ qw(Content-Type application/gzip),
+ 'Content-Disposition', "inline; filename=$fn.mbox.gz" ];
+ [ 200, $h, $body ];
}
sub gzip_fail ($$) {
diff --git a/t/psgi_search.t b/t/psgi_search.t
index 56b42118..4ff25eb2 100644
--- a/t/psgi_search.t
+++ b/t/psgi_search.t
@@ -107,6 +107,12 @@ test_psgi(sub { $www->call(@_) }, sub {
'subject-less message linked from "/$INBOX/?q=..."');
like($html, qr/\bhref="blank-subject[^>]+>\(no subject\)</,
'blank subject message linked from "/$INBOX/?q=..."');
+ $res = $cb->(GET('/test/no-subject-at-all@example.com/raw'));
+ like($res->header('Content-Disposition'),
+ qr/filename=no-subject\.txt/);
+ $res = $cb->(GET('/test/no-subject-at-all@example.com/t.mbox.gz'));
+ like($res->header('Content-Disposition'),
+ qr/filename=no-subject\.mbox\.gz/);
});
done_testing();
^ permalink raw reply related [relevance 7%]
* [PATCH 0/2] subject-free tests and updates
@ 2020-01-30 9:19 5% Eric Wong
2020-01-30 9:19 7% ` [PATCH 2/2] mboxgz: ensure gzipped mboxes always have filenames Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-01-30 9:19 UTC (permalink / raw)
To: meta
Odd cases need more coverage...
Eric Wong (2):
t/psgi_search: test for subject-free messages
mboxgz: ensure gzipped mboxes always have filenames
lib/PublicInbox/MboxGz.pm | 10 ++++------
t/psgi_search.t | 39 +++++++++++++++++++++++++++++++++++++--
2 files changed, 41 insertions(+), 8 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-01-30 9:19 5% [PATCH 0/2] subject-free tests and updates Eric Wong
2020-01-30 9:19 7% ` [PATCH 2/2] mboxgz: ensure gzipped mboxes always have filenames Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).