* [PATCH 4/7] mbox: remove feed dependency
2016-06-20 0:57 7% [PATCH 0/7] www: various feed/streaming related cleanups Eric Wong
@ 2016-06-20 0:57 6% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-06-20 0:57 UTC (permalink / raw)
To: meta
We do not need feed options there (or anywhere, hopefully).
---
lib/PublicInbox/Mbox.pm | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/lib/PublicInbox/Mbox.pm b/lib/PublicInbox/Mbox.pm
index 7934876..1c792c8 100644
--- a/lib/PublicInbox/Mbox.pm
+++ b/lib/PublicInbox/Mbox.pm
@@ -32,19 +32,14 @@ sub emit_msg {
foreach my $d (qw(Lines Bytes Content-Length Status)) {
$header_obj->header_set($d);
}
- my $feed_opts = $ctx->{feed_opts};
- unless ($feed_opts) {
- require PublicInbox::Feed; # FIXME: gross
- $feed_opts = PublicInbox::Feed::get_feedopts($ctx);
- $ctx->{feed_opts} = $feed_opts;
- }
- my $base = $feed_opts->{url};
+ my $ibx = $ctx->{-inbox};
+ my $base = $ibx->base_url($ctx->{cgi});
my $mid = mid_clean($header_obj->header('Message-ID'));
$mid = uri_escape_utf8($mid);
my @append = (
'Archived-At', "<$base$mid/>",
'List-Archive', "<$base>",
- 'List-Post', "<mailto:$feed_opts->{id_addr}>",
+ 'List-Post', "<mailto:$ibx->{-primary_address}>",
);
my $append = '';
my $crlf = $simple->crlf;
^ permalink raw reply related [relevance 6%]
* [PATCH 0/7] www: various feed/streaming related cleanups
@ 2016-06-20 0:57 7% Eric Wong
2016-06-20 0:57 6% ` [PATCH 4/7] mbox: remove feed dependency Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-06-20 0:57 UTC (permalink / raw)
To: meta
Yet more progress towards converting our PSGI streaming
interfaces over to getline/close so it can be pull-based.
Eric Wong (7):
MANIFEST: update with recent changes
feed: avoid needless method dispatches on 404
feed: remove dependence on fh->write for streaming
mbox: remove feed dependency
mbox: avoid write dependency for streaming
feed: various object-orientation cleanups
inbox: move field population logic to initializer
.gitignore | 1 +
MANIFEST | 2 +
Makefile.PL | 5 ++-
lib/PublicInbox/Config.pm | 4 +-
lib/PublicInbox/Feed.pm | 99 ++++++++++++++++++-------------------------
lib/PublicInbox/Inbox.pm | 15 +++++++
lib/PublicInbox/Mbox.pm | 68 ++++++++++-------------------
lib/PublicInbox/NNTP.pm | 6 +--
lib/PublicInbox/SearchView.pm | 3 +-
lib/PublicInbox/View.pm | 7 +--
lib/PublicInbox/WWW.pm | 4 +-
lib/PublicInbox/WwwAttach.pm | 5 +--
t/feed.t | 44 ++++++-------------
t/html_index.t | 11 ++++-
14 files changed, 119 insertions(+), 155 deletions(-)
^ permalink raw reply [relevance 7%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-06-20 0:57 7% [PATCH 0/7] www: various feed/streaming related cleanups Eric Wong
2016-06-20 0:57 6% ` [PATCH 4/7] mbox: remove feed dependency Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).