* [PATCH] lock: show failure path
@ 2020-07-30 8:05 7% Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2020-07-30 8:05 UTC (permalink / raw)
To: meta
This ought to be useful for diagnosing bugs in -watch.
---
Tracking down a problem in -watch with Maildirs...
lib/PublicInbox/Lock.pm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/Lock.pm b/lib/PublicInbox/Lock.pm
index c0d4d3b3..ca43682f 100644
--- a/lib/PublicInbox/Lock.pm
+++ b/lib/PublicInbox/Lock.pm
@@ -12,8 +12,9 @@ use Carp qw(croak);
# PublicInbox::Import already has the lock on its own.
sub lock_acquire {
my ($self) = @_;
- croak 'already locked' if $self->{lockfh};
- my $lock_path = $self->{lock_path} or return;
+ my $lock_path = $self->{lock_path};
+ croak 'already locked '.($lock_path // '(undef)') if $self->{lockfh};
+ return unless defined($lock_path);
sysopen(my $lockfh, $lock_path, O_WRONLY|O_CREAT) or
die "failed to open lock $lock_path: $!\n";
flock($lockfh, LOCK_EX) or die "lock failed: $!\n";
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-07-30 8:05 7% [PATCH] lock: show failure path Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).