* [PATCH 3/5] lei_store: set_xvmd: don't add if no vmd at all
2021-04-01 12:10 5% [PATCH 0/5] quieter and less noisy Eric Wong
@ 2021-04-01 12:10 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-04-01 12:10 UTC (permalink / raw)
To: meta
There's no point in adding vmd information for an external
message if it was never stored and there's no vmd at all.
We also don't need to check _docids_for for similar messages,
either, since we always check lse->kw_changed, first.
---
lib/PublicInbox/LeiStore.pm | 18 +++++-------------
1 file changed, 5 insertions(+), 13 deletions(-)
diff --git a/lib/PublicInbox/LeiStore.pm b/lib/PublicInbox/LeiStore.pm
index 48ab1d76..f2aa45bd 100644
--- a/lib/PublicInbox/LeiStore.pm
+++ b/lib/PublicInbox/LeiStore.pm
@@ -307,19 +307,11 @@ sub set_xvmd {
}
return unless scalar(keys(%$xoids));
- # see if it was indexed, but with different OID(s)
- if (my @docids = _docids_for($self, $eml)) {
- for my $docid (@docids) {
- next if $seen{$docid};
- for my $oid (keys %$xoids) {
- $oidx->add_xref3($docid, -1, $oid, '.');
- }
- my $idx = $eidx->idx_shard($docid);
- $idx->ipc_do('set_vmd', $docid, $vmd);
- }
- return;
- }
- # totally unseen
+ # n.b. we don't do _docids_for here, we expect the caller
+ # already checked $lse->kw_changed before calling this sub
+
+ return unless (@{$vmd->{kw} // []}) || (@{$vmd->{L} // []});
+ # totally unseen:
my ($smsg, $idx) = _external_only($self, $xoids, $eml);
$idx->ipc_do('add_vmd', $smsg->{num}, $vmd);
}
^ permalink raw reply related [relevance 7%]
* [PATCH 0/5] quieter and less noisy
@ 2021-04-01 12:10 5% Eric Wong
2021-04-01 12:10 7% ` [PATCH 3/5] lei_store: set_xvmd: don't add if no vmd at all Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-04-01 12:10 UTC (permalink / raw)
To: meta
Some things that came up while working on making repeated/saved
searches faster...
Eric Wong (5):
lei_query: remove unnecessary V2Writable require
lei q: reduce lei/store work for kw changes to stored mail
lei_store: set_xvmd: don't add if no vmd at all
lei_store: quiet down git user info being unset
lei_store: quiet down per-message related warnings
lib/PublicInbox/LeiQuery.pm | 1 -
lib/PublicInbox/LeiSearch.pm | 9 +++++----
lib/PublicInbox/LeiStore.pm | 33 ++++++++++++++-------------------
lib/PublicInbox/LeiToMail.pm | 6 +++---
4 files changed, 22 insertions(+), 27 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-04-01 12:10 5% [PATCH 0/5] quieter and less noisy Eric Wong
2021-04-01 12:10 7% ` [PATCH 3/5] lei_store: set_xvmd: don't add if no vmd at all Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).