* [PATCH] lei_search: avoid unconditional warning when no exception
@ 2021-08-16 5:39 7% Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2021-08-16 5:39 UTC (permalink / raw)
To: meta
Oops, we shouldn't warn on "$@" unless "$@" is truthy.
Fixes: c7bcfe6cd6648ff0 ("lei: diagnostics for /Document \d+ not found/ errors")
---
lib/PublicInbox/LeiSearch.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/LeiSearch.pm b/lib/PublicInbox/LeiSearch.pm
index f9e5c8e9..47160ed9 100644
--- a/lib/PublicInbox/LeiSearch.pm
+++ b/lib/PublicInbox/LeiSearch.pm
@@ -64,7 +64,8 @@ sub _xsmsg_vmd { # retry_reopen
%L = (%L, %$x);
}
};
- warn "$$ $0 #$num (nshard=$self->{nshard}) $smsg->{blob}: $@";
+ warn "$$ $0 #$num (nshard=$self->{nshard}) $smsg->{blob}: $@"
+ if $@;
}
$smsg->{kw} = [ sort keys %kw ] if scalar(keys(%kw));
$smsg->{L} = [ sort keys %L ] if scalar(keys(%L));
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-08-16 5:39 7% [PATCH] lei_search: avoid unconditional warning when no exception Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).