* [PATCH 3/6] lei_saved_search: avoid needless var shadowing
2021-04-19 8:52 7% [PATCH 0/6] lei saved search improvements Eric Wong
@ 2021-04-19 8:52 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-04-19 8:52 UTC (permalink / raw)
To: meta
While perl (5.28) doesn't complain about this, it's confusing to
my easily-confused mind.
---
lib/PublicInbox/LeiSavedSearch.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/LeiSavedSearch.pm b/lib/PublicInbox/LeiSavedSearch.pm
index 94920a4e..19f4aa5f 100644
--- a/lib/PublicInbox/LeiSavedSearch.pm
+++ b/lib/PublicInbox/LeiSavedSearch.pm
@@ -79,7 +79,7 @@ sub new {
$self->{-cfg} //= PublicInbox::Config::git_config_dump($f);
$self->{'-f'} = $f;
} else { # new saved search "lei q --save"
- my $dst = $lei->{ovv}->{dst};
+ $dst = $lei->{ovv}->{dst};
$dir = lss_dir_for($lei, \$dst);
require File::Path;
File::Path::make_path($dir); # raises on error
^ permalink raw reply related [relevance 7%]
* [PATCH 0/6] lei saved search improvements
@ 2021-04-19 8:52 7% Eric Wong
2021-04-19 8:52 7% ` [PATCH 3/6] lei_saved_search: avoid needless var shadowing Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-04-19 8:52 UTC (permalink / raw)
To: meta
I think the "lei q --save" and "lei up" commands are in a good
state. There's no way to edit/forget saved searches, yet,
so I guess that's next...
Eric Wong (6):
lei: support unlinked/missing saved searches
lei q: implement import-before default for --save
lei_saved_search: avoid needless var shadowing
config: git_config_dump blesses
lei_saved_search: split "lei q --save" and "lei up" init paths
lei q: --save and --augment may be combined
lib/PublicInbox/Config.pm | 10 ++--
lib/PublicInbox/LEI.pm | 3 +-
lib/PublicInbox/LeiLsSearch.pm | 2 +-
lib/PublicInbox/LeiMirror.pm | 2 +-
lib/PublicInbox/LeiSavedSearch.pm | 94 +++++++++++++++----------------
lib/PublicInbox/LeiToMail.pm | 6 +-
lib/PublicInbox/LeiUp.pm | 4 +-
t/lei-q-save.t | 41 ++++++++++++++
8 files changed, 101 insertions(+), 61 deletions(-)
^ permalink raw reply [relevance 7%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-04-19 8:52 7% [PATCH 0/6] lei saved search improvements Eric Wong
2021-04-19 8:52 7% ` [PATCH 3/6] lei_saved_search: avoid needless var shadowing Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).