* [PATCH 2/6] lei_external: remove unnecessary Exporter use
2021-02-10 7:07 6% [PATCH 0/6] more lei stuffs Eric Wong
@ 2021-02-10 7:07 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-02-10 7:07 UTC (permalink / raw)
To: meta
We don't need to export for methods which are only called via
"->" or "->can".
---
lib/PublicInbox/LeiExternal.pm | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/PublicInbox/LeiExternal.pm b/lib/PublicInbox/LeiExternal.pm
index bac15226..b4e1918d 100644
--- a/lib/PublicInbox/LeiExternal.pm
+++ b/lib/PublicInbox/LeiExternal.pm
@@ -5,8 +5,6 @@
package PublicInbox::LeiExternal;
use strict;
use v5.10.1;
-use parent qw(Exporter);
-our @EXPORT = qw(lei_ls_external lei_add_external lei_forget_external);
use PublicInbox::Config;
sub externals_each {
^ permalink raw reply related [relevance 7%]
* [PATCH 0/6] more lei stuffs
@ 2021-02-10 7:07 6% Eric Wong
2021-02-10 7:07 7% ` [PATCH 2/6] lei_external: remove unnecessary Exporter use Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-02-10 7:07 UTC (permalink / raw)
To: meta
IMAP and NNTP lei-import support are coming. Basically stuff in
-watch, but IMAP will need to support flags (aka keywords) in
IMAP.
"lei ls-external" gains filtering + globbing support
(still needs shell completion support)
Eric Wong (6):
lei *external: glob improvements, ls-external filtering
lei_external: remove unnecessary Exporter use
test_common: support lei-daemon only testing
lei ls-external: support --local and --remote
lei: note some TODO items (curl, externals)
net_reader: new package split from -watch
MANIFEST | 1 +
lib/PublicInbox/LEI.pm | 4 +-
lib/PublicInbox/LeiCurl.pm | 2 +
lib/PublicInbox/LeiExternal.pm | 85 +++++++++----
lib/PublicInbox/NetReader.pm | 220 +++++++++++++++++++++++++++++++++
lib/PublicInbox/TestCommon.pm | 13 +-
lib/PublicInbox/Watch.pm | 204 +-----------------------------
t/lei-externals.t | 36 ++++--
t/lei_external.t | 20 ++-
9 files changed, 343 insertions(+), 242 deletions(-)
create mode 100644 lib/PublicInbox/NetReader.pm
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-02-10 7:07 6% [PATCH 0/6] more lei stuffs Eric Wong
2021-02-10 7:07 7% ` [PATCH 2/6] lei_external: remove unnecessary Exporter use Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).