* [PATCH 3/4] lei: use scalar %SIG assignment
2023-09-24 21:08 5% [PATCH 0/4] various CentOS 7.x related fixes Eric Wong
@ 2023-09-24 21:08 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2023-09-24 21:08 UTC (permalink / raw)
To: meta
Perl v5.16.3 (and possibly some later versions) complain about
this, but newer (v5.32.1) are fine with it.
Fixes: e281363ba937 ("lei: ensure we run DESTROY|END at daemon exit w/ kqueue")
---
lib/PublicInbox/LEI.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm
index 1ead9bf6..be77fa90 100644
--- a/lib/PublicInbox/LEI.pm
+++ b/lib/PublicInbox/LEI.pm
@@ -1381,9 +1381,9 @@ sub lazy_start {
PublicInbox::DS::sig_setmask($oldset) if @kq_ign;
# exit() may trigger waitpid via various DESTROY, ensure interruptible
- local @SIG{TERM} = sub { exit(POSIX::SIGTERM + 128) };
- local @SIG{INT} = sub { exit(POSIX::SIGINT + 128) };
- local @SIG{QUIT} = sub { exit(POSIX::SIGQUIT + 128) };
+ local $SIG{TERM} = sub { exit(POSIX::SIGTERM + 128) };
+ local $SIG{INT} = sub { exit(POSIX::SIGINT + 128) };
+ local $SIG{QUIT} = sub { exit(POSIX::SIGQUIT + 128) };
PublicInbox::DS::sig_setmask($oldset) if !@kq_ign;
dump_and_clear_log();
exit($exit_code // 0);
^ permalink raw reply related [relevance 7%]
* [PATCH 0/4] various CentOS 7.x related fixes
@ 2023-09-24 21:08 5% Eric Wong
2023-09-24 21:08 7% ` [PATCH 3/4] lei: use scalar %SIG assignment Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2023-09-24 21:08 UTC (permalink / raw)
To: meta
Still not sure how to best handle 3rd-party repos from
install/deps...
Eric Wong (4):
test_common: force IPv4 with pre-IPv6 Net::POP3
install/deps: fix RPM installation of some packages
lei: use scalar %SIG assignment
xap_helper.h: add missing headers and avoid reallocarray
install/deps.perl | 8 ++++++--
lib/PublicInbox/LEI.pm | 6 +++---
lib/PublicInbox/TestCommon.pm | 1 +
lib/PublicInbox/xap_helper.h | 7 +++++--
t/pop3d-limit.t | 2 +-
5 files changed, 16 insertions(+), 8 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2023-09-24 21:08 5% [PATCH 0/4] various CentOS 7.x related fixes Eric Wong
2023-09-24 21:08 7% ` [PATCH 3/4] lei: use scalar %SIG assignment Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).