* [PATCH 2/6] lei: dclose: do not EPOLL_CTL_DEL w/o event_init
2021-03-04 9:03 5% [PATCH 0/6] lei q --import-augment => --import-before; mbox + IMAP Eric Wong
@ 2021-03-04 9:03 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-03-04 9:03 UTC (permalink / raw)
To: meta
It's possible we'll hit a die() statement which triggers
lei->dclose, but aren't in the event loop, yet.
---
lib/PublicInbox/LEI.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm
index 1e5b04ca..fdd9f8c8 100644
--- a/lib/PublicInbox/LEI.pm
+++ b/lib/PublicInbox/LEI.pm
@@ -973,7 +973,7 @@ sub dclose {
if (my $sto = delete $self->{sto}) {
$sto->ipc_do('done');
}
- $self->close if $self->{sock}; # PublicInbox::DS::close
+ $self->close if $self->{-event_init_done}; # PublicInbox::DS::close
}
# for long-running results
^ permalink raw reply related [relevance 7%]
* [PATCH 0/6] lei q --import-augment => --import-before; mbox + IMAP
@ 2021-03-04 9:03 5% Eric Wong
2021-03-04 9:03 7% ` [PATCH 2/6] lei: dclose: do not EPOLL_CTL_DEL w/o event_init Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-03-04 9:03 UTC (permalink / raw)
To: meta
mbox support was the trickiest, and necessitated
PATCH 2/6 and 3/6 in addition to
https://public-inbox.org/meta/20210304012039.26900-1-e@80x24.org/
("ds: import croak properly")
6/6 completes the renaming.
Eric Wong (6):
lei q: support --import-augment for IMAP
lei: dclose: do not EPOLL_CTL_DEL w/o event_init
lei_xsearch: cleanup {pkt_op_p} on exceptions
lei q: --import-augment for mbox and mbox.gz
t/lei_to_mail: no need to cat in FIFO test
lei q: s/import-augment/import-before/g
lib/PublicInbox/LEI.pm | 4 +-
lib/PublicInbox/LeiQuery.pm | 2 +-
lib/PublicInbox/LeiToMail.pm | 115 +++++++++++++++++++++++-----------
lib/PublicInbox/LeiXSearch.pm | 6 ++
lib/PublicInbox/NetReader.pm | 9 ++-
lib/PublicInbox/NetWriter.pm | 41 ++++++++++--
t/lei-q-kw.t | 80 +++++++++++++++++++++--
t/lei_to_mail.t | 7 ++-
xt/net_writer-imap.t | 36 +++++++++--
9 files changed, 241 insertions(+), 59 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-03-04 9:03 5% [PATCH 0/6] lei q --import-augment => --import-before; mbox + IMAP Eric Wong
2021-03-04 9:03 7% ` [PATCH 2/6] lei: dclose: do not EPOLL_CTL_DEL w/o event_init Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).