* [PATCH 2/5] lei/store: use remove_doc to save some LoC
2021-10-12 22:44 5% [PATCH 0/5] fix extindex reindex harder Eric Wong
@ 2021-10-12 22:44 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-10-12 22:44 UTC (permalink / raw)
To: meta
---
lib/PublicInbox/LeiStore.pm | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/PublicInbox/LeiStore.pm b/lib/PublicInbox/LeiStore.pm
index 613d1d31f581..bf41dcf53094 100644
--- a/lib/PublicInbox/LeiStore.pm
+++ b/lib/PublicInbox/LeiStore.pm
@@ -281,8 +281,7 @@ sub remove_docids ($;@) {
my ($self, @docids) = @_;
my $eidx = eidx_init($self);
for my $docid (@docids) {
- $eidx->idx_shard($docid)->ipc_do('xdb_remove', $docid);
- $eidx->{oidx}->delete_by_num($docid);
+ $eidx->remove_doc($docid);
$eidx->{oidx}->{dbh}->do(<<EOF, undef, $docid);
DELETE FROM xref3 WHERE docid = ?
EOF
^ permalink raw reply related [relevance 7%]
* [PATCH 0/5] fix extindex reindex harder
@ 2021-10-12 22:44 5% Eric Wong
2021-10-12 22:44 7% ` [PATCH 2/5] lei/store: use remove_doc to save some LoC Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-10-12 22:44 UTC (permalink / raw)
To: meta
1/5 may affect some users
3/5 quiets things down for users on SQLite <3.18
5/5 is a good usability fix for me
Eric Wong (5):
extindex: flush pending reindex before unref
lei/store: use remove_doc to save some LoC
index: optimize after all SQLite DB commits
doc: relnotes: note some recent improvements
lei up --all: show output for warnings
Documentation/RelNotes/v1.7.0.wip | 14 +++++++++++++-
lib/PublicInbox/ExtSearchIdx.pm | 4 ++++
lib/PublicInbox/LEI.pm | 12 ++++++++----
lib/PublicInbox/LeiMailSync.pm | 2 +-
lib/PublicInbox/LeiStore.pm | 3 +--
lib/PublicInbox/LeiUp.pm | 7 +++++++
lib/PublicInbox/OverIdx.pm | 1 +
lib/PublicInbox/SearchIdx.pm | 1 +
lib/PublicInbox/V2Writable.pm | 16 +++++-----------
9 files changed, 41 insertions(+), 19 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-10-12 22:44 5% [PATCH 0/5] fix extindex reindex harder Eric Wong
2021-10-12 22:44 7% ` [PATCH 2/5] lei/store: use remove_doc to save some LoC Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).