user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH 1/2] lei rediff: quiet warnings from Import and Eml
  2021-09-27  4:59  6% [PATCH 0/2] lei rediff: --drq and --dequote-only Eric Wong
@ 2021-09-27  4:59  7% ` Eric Wong
  0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-09-27  4:59 UTC (permalink / raw)
  To: meta

lei rediff is expected to see partial patch fragments and such,
so silence warnings when something isn't exactly a valid email
message.
---
 lib/PublicInbox/LeiRediff.pm | 11 +++++++++--
 t/solver_git.t               |  1 +
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/LeiRediff.pm b/lib/PublicInbox/LeiRediff.pm
index ea9b2a643f9a..f6960560f1a2 100644
--- a/lib/PublicInbox/LeiRediff.pm
+++ b/lib/PublicInbox/LeiRediff.pm
@@ -193,8 +193,15 @@ sub extract_oids { # Eml each_part callback
 
 sub input_eml_cb { # callback for all emails
 	my ($self, $eml) = @_;
-	$self->{tmp_sto}->add_eml($eml);
-	$self->{tmp_sto}->done;
+	{
+		local $SIG{__WARN__} = sub {
+			return if "@_" =~ /^no email in From: .*? or Sender:/;
+			return if PublicInbox::Eml::warn_ignore(@_);
+			warn @_;
+		};
+		$self->{tmp_sto}->add_eml($eml);
+		$self->{tmp_sto}->done;
+	}
 	$eml->each_part(\&extract_oids, $self, 1);
 }
 
diff --git a/t/solver_git.t b/t/solver_git.t
index d5f4c4a02758..3c0b7f6524c6 100644
--- a/t/solver_git.t
+++ b/t/solver_git.t
@@ -93,6 +93,7 @@ index 15ac20eb..771486c4
 EOM
 	like($lei_out, qr/\Q$exp\E/,
 		'preserve mode, regen header + context from -U0 patch');
+	is($lei_err, '', 'no warnings from bare patch');
 	my $e = { GIT_DIR => "$ENV{HOME}/.local/share/lei/store/ALL.git" };
 	my @x = xqx([qw(git cat-file --batch-all-objects --batch-check)], $e);
 	is_deeply(\@x, [], 'no objects stored') or diag explain(\@x);

^ permalink raw reply related	[relevance 7%]

* [PATCH 0/2] lei rediff: --drq and --dequote-only
@ 2021-09-27  4:59  6% Eric Wong
  2021-09-27  4:59  7% ` [PATCH 1/2] lei rediff: quiet warnings from Import and Eml Eric Wong
  0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-09-27  4:59 UTC (permalink / raw)
  To: meta

Things to make lei-rediff more useful inside a text editor
while writing replies to patch emails.

Eric Wong (2):
  lei rediff: quiet warnings from Import and Eml
  lei rediff: add --drq and --dequote-only

 Documentation/lei-rediff.pod | 27 +++++++++++++++++
 lib/PublicInbox/LEI.pm       |  2 +-
 lib/PublicInbox/LeiRediff.pm | 58 ++++++++++++++++++++++++++++++++++--
 t/solver_git.t               | 41 +++++++++++++++++++++++--
 4 files changed, 123 insertions(+), 5 deletions(-)

^ permalink raw reply	[relevance 6%]

Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-09-27  4:59  6% [PATCH 0/2] lei rediff: --drq and --dequote-only Eric Wong
2021-09-27  4:59  7% ` [PATCH 1/2] lei rediff: quiet warnings from Import and Eml Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).