* [PATCH 2/3] lei q: reduce default lei2mail workers
2021-02-23 10:01 6% [PATCH 0/3] lei -C DIR and more Eric Wong
@ 2021-02-23 10:01 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-02-23 10:01 UTC (permalink / raw)
To: meta
While disk I/O is typically buffered for good scheduling,
git blob decoding uses a non-trivial amount of CPU time
and it helps to leave some CPU available for it.
---
lib/PublicInbox/LeiQuery.pm | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/LeiQuery.pm b/lib/PublicInbox/LeiQuery.pm
index 214267ee..743fa3f7 100644
--- a/lib/PublicInbox/LeiQuery.pm
+++ b/lib/PublicInbox/LeiQuery.pm
@@ -5,6 +5,7 @@
package PublicInbox::LeiQuery;
use strict;
use v5.10.1;
+use POSIX ();
sub prep_ext { # externals_each callback
my ($lxs, $exclude, $loc) = @_;
@@ -94,7 +95,10 @@ sub lei_q {
return $self->fail("`$mj' writer jobs must be >= 1");
}
PublicInbox::LeiOverview->new($self) or return;
- $self->{l2m}->{-wq_nr_workers} = ($mj // $nproc) if $self->{l2m};
+ $self->{l2m} and $self->{l2m}->{-wq_nr_workers} = $mj // do {
+ $mj = POSIX::lround($nproc * 3 / 4); # keep some CPU for git
+ $mj <= 0 ? 1 : $mj;
+ };
my %mset_opt = map { $_ => $opt->{$_} } qw(threads limit offset);
$mset_opt{asc} = $opt->{'reverse'} ? 1 : 0;
^ permalink raw reply related [relevance 7%]
* [PATCH 0/3] lei -C DIR and more
@ 2021-02-23 10:01 6% Eric Wong
2021-02-23 10:01 7% ` [PATCH 2/3] lei q: reduce default lei2mail workers Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-02-23 10:01 UTC (permalink / raw)
To: meta
Like git, make, and tar: "lei -C DIR" now works.
I may add "lei -c config.key=config.val" for IMAP / NNTP
support, too (working on NNTP).
Eric Wong (3):
lei: support "-C" to chdir in all sub commands
lei q: reduce default lei2mail workers
lei_to_mail: remove unused OnDestroy import
lib/PublicInbox/LEI.pm | 74 +++++++++++++++++++++---------------
lib/PublicInbox/LeiQuery.pm | 6 ++-
lib/PublicInbox/LeiToMail.pm | 1 -
t/lei-externals.t | 22 +++++++++++
t/lei.t | 4 ++
5 files changed, 74 insertions(+), 33 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-02-23 10:01 6% [PATCH 0/3] lei -C DIR and more Eric Wong
2021-02-23 10:01 7% ` [PATCH 2/3] lei q: reduce default lei2mail workers Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).