* [PATCH 08/11] lei q: prefix --alert ops with ':' instead of '-'
2021-02-09 8:09 6% [PATCH 00/11] Maildir code consolidation, test updates Eric Wong
@ 2021-02-09 8:09 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-02-09 8:09 UTC (permalink / raw)
To: meta
Using dashed keywords confuses the option parser without
"=" signs (and bash completion doesn't yet work with "=").
So use ":" instead of "-" as the prefix for internal ops,
since ":" is just as unlikely to be the first character of
an executable file in a user's $PATH.
---
lib/PublicInbox/LEI.pm | 8 ++++----
lib/PublicInbox/LeiOverview.pm | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm
index e2a945a4..e29b13c3 100644
--- a/lib/PublicInbox/LEI.pm
+++ b/lib/PublicInbox/LEI.pm
@@ -227,9 +227,9 @@ my %OPTDESC = (
'show threads|t' => 'display entire thread a message belongs to',
'q threads|t' =>
'return all messages in the same threads as the actual match(es)',
-'alert=s@' => ['CMD,-WINCH,-bell,<any command>',
+'alert=s@' => ['CMD,:WINCH,:bell,<any command>',
'run command(s) or perform ops when done writing to output ' .
- '(default: "-WINCH,-bell" with --mua and Maildir/IMAP output, ' .
+ '(default: ":WINCH,:bell" with --mua and Maildir/IMAP output, ' .
'nothing otherwise)' ],
'augment|a' => 'augment --output destination instead of clobbering',
@@ -758,14 +758,14 @@ sub poke_mua { # forces terminal MUAs to wake up and hopefully notice new mail
my ($self) = @_;
my $alerts = $self->{opt}->{alert} // return;
while (my $op = shift(@$alerts)) {
- if ($op eq '-WINCH') {
+ if ($op eq ':WINCH') {
# hit the process group that started the MUA
if ($self->{sock}) {
send($self->{sock}, '-WINCH', MSG_EOR);
} elsif ($self->{oneshot}) {
kill('-WINCH', $$);
}
- } elsif ($op eq '-bell') {
+ } elsif ($op eq ':bell') {
out($self, "\a");
} elsif ($op =~ /(?<!\\),/) { # bare ',' (not ',,')
push @$alerts, split(/(?<!\\),/, $op);
diff --git a/lib/PublicInbox/LeiOverview.pm b/lib/PublicInbox/LeiOverview.pm
index 98c89d12..c820f0d7 100644
--- a/lib/PublicInbox/LeiOverview.pm
+++ b/lib/PublicInbox/LeiOverview.pm
@@ -100,7 +100,7 @@ sub new {
return $lei->fail($@) if $@;
if ($opt->{mua} && $lei->{l2m}->lock_free) {
$lei->{early_mua} = 1;
- $opt->{alert} //= [ '-WINCH,-bell' ] if -t $lei->{1};
+ $opt->{alert} //= [ ':WINCH,:bell' ] if -t $lei->{1};
}
}
$self;
^ permalink raw reply related [relevance 7%]
* [PATCH 00/11] Maildir code consolidation, test updates
@ 2021-02-09 8:09 6% Eric Wong
2021-02-09 8:09 7% ` [PATCH 08/11] lei q: prefix --alert ops with ':' instead of '-' Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-02-09 8:09 UTC (permalink / raw)
To: meta
MdirReader is the home of Maildir-related code, and
-watch is updated to use some of it, as is the
InboxWritable->import_maildir (which I'm not sure
should live).
"lei q --alert=" is slightly changed for CLI-friendliness
tr/-/:/
And damn, I just misread "Cwd" as "Covid"; /me goes back
to hiding under the bed :<
Eric Wong (11):
t/thread-index-gap.t: avoid unnecessary map
test_common: disable fsync on the command-line where possible
t/cgi.t: modernizations and style updates
git: ->qx: respect caller's $/ in array context
lei: split out MdirReader package, lazy-require earlier
t/run.perl: fix for >128 tests
use MdirReader in -watch and InboxWritable
lei q: prefix --alert ops with ':' instead of '-'
t/run.perl: drop Cwd dependency
lei: replace "I:"-prefixed info messages with "#"
tests: (lei) fixes for TEST_RUN_MODE=0 and oneshot mode
MANIFEST | 2 +
lib/PublicInbox/Git.pm | 1 -
lib/PublicInbox/IPC.pm | 2 +
lib/PublicInbox/Import.pm | 6 +--
lib/PublicInbox/InboxWritable.pm | 55 +++++++++------------
lib/PublicInbox/LEI.pm | 21 ++++----
lib/PublicInbox/LeiImport.pm | 25 ++++++----
lib/PublicInbox/LeiOverview.pm | 2 +-
lib/PublicInbox/LeiToMail.pm | 26 ++++------
lib/PublicInbox/MdirReader.pm | 39 +++++++++++++++
lib/PublicInbox/TestCommon.pm | 10 +++-
lib/PublicInbox/Watch.pm | 6 ++-
t/cgi.t | 84 +++++++++++++-------------------
t/lei-import.t | 5 +-
t/lei-mirror.t | 2 +-
t/lei.t | 2 +-
t/lei_to_mail.t | 19 ++++++--
t/mdir_reader.t | 22 +++++++++
t/run.perl | 22 ++++-----
t/thread-index-gap.t | 10 ++--
20 files changed, 211 insertions(+), 150 deletions(-)
create mode 100644 lib/PublicInbox/MdirReader.pm
create mode 100644 t/mdir_reader.t
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-02-09 8:09 6% [PATCH 00/11] Maildir code consolidation, test updates Eric Wong
2021-02-09 8:09 7% ` [PATCH 08/11] lei q: prefix --alert ops with ':' instead of '-' Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).