* [PATCH 1/7] ipc: some documentation comments
2021-01-03 2:06 5% [PATCH 0/7] v2: swap in new IPC package Eric Wong
@ 2021-01-03 2:06 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-01-03 2:06 UTC (permalink / raw)
To: meta
Fix some comments and add some short summary descriptions to
hopefully make things easier-to-follow.
---
lib/PublicInbox/IPC.pm | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/IPC.pm b/lib/PublicInbox/IPC.pm
index 288a8c94..79cd34fe 100644
--- a/lib/PublicInbox/IPC.pm
+++ b/lib/PublicInbox/IPC.pm
@@ -10,7 +10,7 @@ use Socket qw(AF_UNIX SOCK_STREAM);
use Carp qw(confess croak);
use PublicInbox::Sigfd;
my ($enc, $dec);
-# ->imports at BEGIN turns serial_*_with_object into custom ops on 5.14+
+# ->imports at BEGIN turns sereal_*_with_object into custom ops on 5.14+
# and eliminate method call overhead
BEGIN {
eval {
@@ -71,9 +71,10 @@ sub ipc_worker_loop ($$) {
}
}
+# starts a worker if Sereal or Storable is installed
sub ipc_worker_spawn {
my ($self, $ident, $oldset) = @_;
- return unless $enc;
+ return unless $enc; # no Sereal or Storable
my $pid = $self->{-ipc_worker_pid};
confess "BUG: already spawned PID:$pid" if $pid;
confess "BUG: already have worker socket" if $self->{-ipc_sock};
@@ -108,15 +109,17 @@ sub ipc_worker_reap { # dwaitpid callback
warn "PID:$pid died with \$?=$?\n" if $?;
}
-# for base class, override in superclasses
+# for base class, override in sub classes
sub ipc_atfork_parent {}
sub ipc_atfork_child {}
+# should only be called inside the worker process
sub ipc_worker_exit {
my (undef, $code) = @_;
exit($code);
}
+# idempotent, can be called regardless of whether worker is active or not
sub ipc_worker_stop {
my ($self) = @_;
my $pid;
@@ -147,6 +150,7 @@ sub ipc_lock_init {
$self->{-ipc_lock} //= bless { lock_path => $f }, 'PublicInbox::Lock'
}
+# call $self->$sub(@args), on a worker if ipc_worker_spawn was used
sub ipc_do {
my ($self, $sub, @args) = @_;
if (my $s1 = $self->{-ipc_sock}) {
^ permalink raw reply related [relevance 7%]
* [PATCH 0/7] v2: swap in new IPC package
@ 2021-01-03 2:06 5% Eric Wong
2021-01-03 2:06 7% ` [PATCH 1/7] ipc: some documentation comments Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-01-03 2:06 UTC (permalink / raw)
To: meta
SearchIdxShard was too big and adding the new extindex
stuff made things worse. Since I intend to use IPC
in more places, I figured it'd be good to prove it with
works well by dropping it into the old v2 mix.
The below diffstat is nice
Eric Wong (7):
ipc: some documentation comments
searchidxshard: use PublicInbox::IPC to kill lots of code
searchidxshard: IPC conversion, part 2
searchidxshard: replace index_raw with index_eml
use Eml (or MIME) objects for all indexing paths
ipc: switch to one-way pipes
searchidxshard: use add_xapian directly for v2
lib/PublicInbox/ExtSearchIdx.pm | 38 +++--
lib/PublicInbox/IPC.pm | 127 +++++++++------
lib/PublicInbox/Import.pm | 4 +-
lib/PublicInbox/LeiStore.pm | 18 +--
lib/PublicInbox/SearchIdx.pm | 35 +---
lib/PublicInbox/SearchIdxShard.pm | 257 +++++-------------------------
lib/PublicInbox/Smsg.pm | 13 ++
lib/PublicInbox/V2Writable.pm | 102 +++++-------
t/import.t | 12 +-
t/search.t | 2 +-
10 files changed, 206 insertions(+), 402 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-01-03 2:06 5% [PATCH 0/7] v2: swap in new IPC package Eric Wong
2021-01-03 2:06 7% ` [PATCH 1/7] ipc: some documentation comments Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).