* [PATCH 1/2] ipc: avoid potential stack-not-refcounted bug
2021-05-25 22:19 5% [PATCH 0/2] ipc: fix "lei q" w/ HTTP(S) externals Eric Wong
@ 2021-05-25 22:20 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-05-25 22:20 UTC (permalink / raw)
To: meta
This fixes a potential problem with Carp::longmess
firing somewhere deeper in the stack. This is not a known
problem at this time, but something I noticed while chasing
something else.
---
lib/PublicInbox/IPC.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/IPC.pm b/lib/PublicInbox/IPC.pm
index cf3723f7..24237773 100644
--- a/lib/PublicInbox/IPC.pm
+++ b/lib/PublicInbox/IPC.pm
@@ -251,7 +251,7 @@ sub wq_worker_loop ($) {
sub do_sock_stream { # via wq_io_do, for big requests
my ($self, $len) = @_;
- recv_and_run($self, delete $self->{0}, $len, 1);
+ recv_and_run($self, my $s2 = delete $self->{0}, $len, 1);
}
sub wq_broadcast {
^ permalink raw reply related [relevance 7%]
* [PATCH 0/2] ipc: fix "lei q" w/ HTTP(S) externals
@ 2021-05-25 22:19 5% Eric Wong
2021-05-25 22:20 7% ` [PATCH 1/2] ipc: avoid potential stack-not-refcounted bug Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-05-25 22:19 UTC (permalink / raw)
To: meta
1/2 was found while making 2/2
Eric Wong (2):
ipc: avoid potential stack-not-refcounted bug
ipc: wq: handle >MAX_ARG_STRLEN && <EMSGSIZE case
lib/PublicInbox/IPC.pm | 47 +++++++++++++++++++++++--------------
lib/PublicInbox/WQWorker.pm | 2 +-
t/ipc.t | 11 ++++++---
3 files changed, 38 insertions(+), 22 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-05-25 22:19 5% [PATCH 0/2] ipc: fix "lei q" w/ HTTP(S) externals Eric Wong
2021-05-25 22:20 7% ` [PATCH 1/2] ipc: avoid potential stack-not-refcounted bug Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).