* [PATCH 2/5] initialize scalar for `vec' perlop modification
2021-01-17 7:09 5% [PATCH 0/5] fixes for older Perls and Xapian Eric Wong
@ 2021-01-17 7:09 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-01-17 7:09 UTC (permalink / raw)
To: meta
From: Eric Wong <e@yhbt.net>
Older Perls (tested 5.16.3) would warn on uninitialized scalars while
newer (tested 5.28.1) do not. Just initialize it to an empty string
since it'll be filled in by `vec'.
---
lib/PublicInbox/LEI.pm | 2 +-
lib/PublicInbox/Syscall.pm | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm
index 1f4a3082..2784ca6b 100644
--- a/lib/PublicInbox/LEI.pm
+++ b/lib/PublicInbox/LEI.pm
@@ -670,7 +670,7 @@ sub accept_dispatch { # Listener {post_accept} callback
my ($sock) = @_; # ignore other
$sock->autoflush(1);
my $self = bless { sock => $sock }, __PACKAGE__;
- vec(my $rvec, fileno($sock), 1) = 1;
+ vec(my $rvec = '', fileno($sock), 1) = 1;
select($rvec, undef, undef, 1) or
return send($sock, 'timed out waiting to recv FDs', MSG_EOR);
my @fds = $recv_cmd->($sock, my $buf, 4096 * 33); # >MAX_ARG_STRLEN
diff --git a/lib/PublicInbox/Syscall.pm b/lib/PublicInbox/Syscall.pm
index a1f53235..5ff1d65f 100644
--- a/lib/PublicInbox/Syscall.pm
+++ b/lib/PublicInbox/Syscall.pm
@@ -224,7 +224,7 @@ sub epoll_ctl_mod8 {
# epoll_wait wrapper
# ARGS: (epfd, maxevents, timeout (milliseconds), arrayref)
# arrayref: values modified to be [$fd, $event]
-our $epoll_wait_events;
+our $epoll_wait_events = '';
our $epoll_wait_size = 0;
sub epoll_wait_mod4 {
my ($epfd, $maxevents, $timeout_msec, $events) = @_;
^ permalink raw reply related [relevance 7%]
* [PATCH 0/5] fixes for older Perls and Xapian
@ 2021-01-17 7:09 5% Eric Wong
2021-01-17 7:09 7% ` [PATCH 2/5] initialize scalar for `vec' perlop modification Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-01-17 7:09 UTC (permalink / raw)
To: meta
Eric Wong (5):
address: pairs: enable pure Perl version
initialize scalar for `vec' perlop modification
t/thread-index-gap: support older DBI
t/shared_kv: workaround old File::Spec
extindex: fix w/ Xapian 1.2.21..1.2.24
lib/PublicInbox/Address.pm | 1 +
lib/PublicInbox/ExtSearchIdx.pm | 1 +
lib/PublicInbox/LEI.pm | 2 +-
lib/PublicInbox/SearchIdx.pm | 5 ++++-
lib/PublicInbox/Syscall.pm | 2 +-
lib/PublicInbox/V2Writable.pm | 12 ++++++++++--
t/shared_kv.t | 10 +++-------
t/thread-index-gap.t | 7 +++++--
8 files changed, 26 insertions(+), 14 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-01-17 7:09 5% [PATCH 0/5] fixes for older Perls and Xapian Eric Wong
2021-01-17 7:09 7% ` [PATCH 2/5] initialize scalar for `vec' perlop modification Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).