user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH 2/3] index: drop signatures from nested output
  @ 2014-09-15 21:01  7% ` Eric Wong
  0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2014-09-15 21:01 UTC (permalink / raw)
  To: meta; +Cc: Eric Wong

We have a less-ambiguous "more..." link nowadays if somebody
wants to see the full message.
---
 lib/PublicInbox/View.pm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index ce63f7d..028c276 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -109,13 +109,13 @@ sub index_entry {
 
 		my $s = add_text_body_short($enc, $part, $part_nr, $fhref);
 
-		# keep signatures for now?  They shold usually be short,
-		# and sometimes footnotes/"P.S." appear there.
-
 		# drop the remainder of git patches, they're usually better
 		# to review when the full message is viewed
 		$s =~ s!^---\n.*\z!!ms and $more = 'more...';
 
+		# Drop signatures
+		$s =~ s/^-- \n.*\z//ms and $more = 'more...';
+
 		# kill any leading or trailing whitespace
 		$s =~ s/\A\s+//s;
 		$s =~ s/\s+\z//s;
-- 
EW


^ permalink raw reply related	[relevance 7%]

Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2014-09-15 21:01     [PATCH 1/3] hval: fixup bad line endings in HTML output Eric Wong
2014-09-15 21:01  7% ` [PATCH 2/3] index: drop signatures from nested output Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).