* [PATCH 3/6] inbox: simplify filtering for duplicate NNTP URLs
2020-01-23 23:05 6% [PATCH 0/6] shorten and simplify uniq logic Eric Wong
@ 2020-01-23 23:05 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-01-23 23:05 UTC (permalink / raw)
To: meta
And add a note to remind ourselves to use List::Util::uniq
when it becomes common.
---
lib/PublicInbox/Inbox.pm | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index e834d565..07e8b5b7 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -293,12 +293,11 @@ sub nntp_url {
# nntp://news.example.com/alt.example
push @m, $u;
}
- my %seen = map { $_ => 1 } @urls;
- foreach my $u (@m) {
- next if $seen{$u};
- $seen{$u} = 1;
- push @urls, $u;
- }
+
+ # List::Util::uniq requires Perl 5.26+, maybe we
+ # can use it by 2030 or so
+ my %seen;
+ @urls = grep { !$seen{$_}++ } (@urls, @m);
}
\@urls;
};
^ permalink raw reply related [relevance 7%]
* [PATCH 0/6] shorten and simplify uniq logic
@ 2020-01-23 23:05 6% Eric Wong
2020-01-23 23:05 7% ` [PATCH 3/6] inbox: simplify filtering for duplicate NNTP URLs Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-01-23 23:05 UTC (permalink / raw)
To: meta
I noticed List::Util 1.45+ includes a new "uniq()" sub, but
that's only distributed with Perl as of 5.26+.
Since we care about supporting older versions of Perl, I still
took the opportunity to simplify some of our own similar logic
for making things unique. It turns out only Inbox->nntp_url
really benefits from List::Util::uniq at the moment, but there's
some small simplifications to be had along the way.
Eric Wong (6):
contentid: use map to generate %seen for Message-Ids
nntp: simplify setting X-Alt-Message-ID
inbox: simplify filtering for duplicate NNTP URLs
mid: shorten uniq_mids logic
wwwstream: shorten cloneurl uniquification
contentid: ignore duplicate References: headers
lib/PublicInbox/ContentId.pm | 12 ++++--------
lib/PublicInbox/Inbox.pm | 11 +++++------
lib/PublicInbox/MID.pm | 4 +---
lib/PublicInbox/NNTP.pm | 5 +----
lib/PublicInbox/OverIdx.pm | 3 +--
lib/PublicInbox/WwwStream.pm | 8 +++-----
6 files changed, 15 insertions(+), 28 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-01-23 23:05 6% [PATCH 0/6] shorten and simplify uniq logic Eric Wong
2020-01-23 23:05 7% ` [PATCH 3/6] inbox: simplify filtering for duplicate NNTP URLs Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).