* [PATCH 4/8] inbox: replace `eval {}' with `do {}' where appropriate
2020-04-18 3:38 4% [PATCH 0/8] some small yak shaving things Eric Wong
@ 2020-04-18 3:38 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-04-18 3:38 UTC (permalink / raw)
To: meta
-Git->new and -Limiter->new will never fail unless there's
an OOM, so using `eval' is incorrect.
---
lib/PublicInbox/Inbox.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index e49f85fc..4bd82989 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -82,7 +82,7 @@ sub _set_uint ($$$) {
sub _set_limiter ($$$) {
my ($self, $pi_config, $pfx) = @_;
my $lkey = "-${pfx}_limiter";
- $self->{$lkey} ||= eval {
+ $self->{$lkey} ||= do {
# full key is: publicinbox.$NAME.httpbackendmax
my $mkey = $pfx.'max';
my $val = $self->{$mkey} or return;
@@ -130,7 +130,7 @@ sub version { $_[0]->{version} // 1 }
sub git_epoch {
my ($self, $epoch) = @_;
$self->version == 2 or return;
- $self->{"$epoch.git"} ||= eval {
+ $self->{"$epoch.git"} ||= do {
my $git_dir = "$self->{inboxdir}/git/$epoch.git";
my $g = PublicInbox::Git->new($git_dir);
$g->{-httpbackend_limiter} = $self->{-httpbackend_limiter};
@@ -141,7 +141,7 @@ sub git_epoch {
sub git {
my ($self) = @_;
- $self->{git} ||= eval {
+ $self->{git} ||= do {
my $git_dir = $self->{inboxdir};
$git_dir .= '/all.git' if $self->version == 2;
my $g = PublicInbox::Git->new($git_dir);
^ permalink raw reply related [relevance 7%]
* [PATCH 0/8] some small yak shaving things
@ 2020-04-18 3:38 4% Eric Wong
2020-04-18 3:38 7% ` [PATCH 4/8] inbox: replace `eval {}' with `do {}' where appropriate Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-04-18 3:38 UTC (permalink / raw)
To: meta
Eric Wong (8):
inboxwritable: mime_from_path: reuse in more places
searchidx: die on cat-file failures
inbox: do not memoize description or cloneurl if missing
inbox: replace `eval {}' with `do {}' where appropriate
favor `do {}' over `eval {}' for localized slurp
wwwatomstream: move {emit_header} field to $self
mbox: use per-message line-ending for From_ line
reduce scope of mbox From_ line removal
Documentation/mknews.perl | 2 +-
MANIFEST | 4 ++--
lib/PublicInbox/Inbox.pm | 27 ++++++++++++------------
lib/PublicInbox/InboxWritable.pm | 4 ++--
lib/PublicInbox/Mbox.pm | 7 +++++--
lib/PublicInbox/NNTP.pm | 2 ++
lib/PublicInbox/SearchIdx.pm | 14 +++++--------
lib/PublicInbox/WatchMaildir.pm | 6 +++---
lib/PublicInbox/WwwAtomStream.pm | 5 ++---
script/public-inbox-edit | 5 ++---
script/public-inbox-learn | 6 +++---
script/public-inbox-mda | 2 +-
script/public-inbox-purge | 2 +-
scripts/import_maildir | 4 ++--
scripts/import_slrnspool | 2 +-
scripts/slrnspool2maildir | 2 +-
scripts/ssoma-replay | 5 +----
t/inbox.t | 19 +++++++++++++++++
t/{iso-2202-jp.mbox => iso-2202-jp.eml} | 1 -
t/mda.t | 10 ++++-----
t/msg_iter.t | 18 ++++++----------
t/nntpd-tls.t | 8 +++----
t/psgi_v2.t | 28 ++++++++++++++++---------
t/search.t | 12 ++++-------
t/solver_git.t | 4 ++--
t/{utf8.mbox => utf8.eml} | 1 -
t/v2reindex.t | 3 +--
t/watch_maildir_v2.t | 2 +-
28 files changed, 105 insertions(+), 100 deletions(-)
rename t/{iso-2202-jp.mbox => iso-2202-jp.eml} (84%)
rename t/{utf8.mbox => utf8.eml} (90%)
^ permalink raw reply [relevance 4%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-04-18 3:38 4% [PATCH 0/8] some small yak shaving things Eric Wong
2020-04-18 3:38 7% ` [PATCH 4/8] inbox: replace `eval {}' with `do {}' where appropriate Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).