* [PATCH 4/5] inbox: remove TODO item for msg_by_path
2020-02-04 4:44 6% [PATCH 0/5] a few more minor fixups Eric Wong
@ 2020-02-04 4:44 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-02-04 4:44 UTC (permalink / raw)
To: meta
It's an old function which only gets called by inboxes w/o
SQLite indices.
---
lib/PublicInbox/Inbox.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index accfd974..a5849a61 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -305,9 +305,9 @@ sub nntp_usable {
$ret;
}
+# for v1 users w/o SQLite only
sub msg_by_path ($$;$) {
my ($self, $path, $ref) = @_;
- # TODO: allow other refs:
my $str = git($self)->cat_file('HEAD:'.$path, $ref);
$$str =~ s/\A[\r\n]*From [^\r\n]*\r?\n//s if $str;
$str;
^ permalink raw reply related [relevance 7%]
* [PATCH 0/5] a few more minor fixups
@ 2020-02-04 4:44 6% Eric Wong
2020-02-04 4:44 7% ` [PATCH 4/5] inbox: remove TODO item for msg_by_path Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-02-04 4:44 UTC (permalink / raw)
To: meta
Nothing earth shattering, serving $INBOX_URL/description
properly for v2 inboxes should make it easier to mirror
while preserving descriptions (only per-epoch descriptions
are propagated in manifest.js.gz).
Eric Wong (5):
www: stricter regexp for 405 errors
www: serve $INBOX_DIR/description as $INBOX_URL/description
inbox: simplify ->description and ->cloneurl
inbox: remove TODO item for msg_by_path
over: simplify read-only vs read-write checking
lib/PublicInbox/Inbox.pm | 26 ++++++++++----------------
lib/PublicInbox/Over.pm | 7 +++----
lib/PublicInbox/OverIdx.pm | 2 +-
lib/PublicInbox/WWW.pm | 13 ++++++++++++-
t/httpd.t | 5 +++++
t/over.t | 7 ++++++-
t/plack.t | 2 ++
t/psgi_v2.t | 3 +++
8 files changed, 42 insertions(+), 23 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-02-04 4:44 6% [PATCH 0/5] a few more minor fixups Eric Wong
2020-02-04 4:44 7% ` [PATCH 4/5] inbox: remove TODO item for msg_by_path Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).