* Re: [PATCH 01/64] inbox: add uidvalidity method
2020-10-16 6:59 6% [PATCH 01/64] inbox: add uidvalidity method Eric Wong
@ 2020-10-16 7:03 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-10-16 7:03 UTC (permalink / raw)
To: meta
Eric Wong <e@80x24.org> wrote:
> This will make it easier to deal with ExtSearchIdx, which
> won't have msgmap.
I was going to send this as a standalone patch (not part of any
series, but it's fine, here).
^ permalink raw reply [relevance 7%]
* [PATCH 01/64] inbox: add uidvalidity method
@ 2020-10-16 6:59 6% Eric Wong
2020-10-16 7:03 7% ` Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-10-16 6:59 UTC (permalink / raw)
To: meta
This will make it easier to deal with ExtSearchIdx, which
won't have msgmap.
---
lib/PublicInbox/DummyInbox.pm | 4 ++--
lib/PublicInbox/IMAPD.pm | 6 +++---
lib/PublicInbox/Inbox.pm | 2 ++
3 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/lib/PublicInbox/DummyInbox.pm b/lib/PublicInbox/DummyInbox.pm
index 69b0b683..02426f13 100644
--- a/lib/PublicInbox/DummyInbox.pm
+++ b/lib/PublicInbox/DummyInbox.pm
@@ -7,13 +7,13 @@
package PublicInbox::DummyInbox;
use strict;
-sub created_at { 0 } # Msgmap::created_at
+sub uidvalidity { 0 } # Msgmap::created_at
sub mm { shift }
sub uid_range { [] } # Over::uid_range
sub subscribe_unlock { undef };
no warnings 'once';
-*max = \&created_at;
+*max = \&uidvalidity;
*query_xover = \&uid_range;
*over = \&mm;
*search = *unsubscribe_unlock =
diff --git a/lib/PublicInbox/IMAPD.pm b/lib/PublicInbox/IMAPD.pm
index 3c211ee1..bb705136 100644
--- a/lib/PublicInbox/IMAPD.pm
+++ b/lib/PublicInbox/IMAPD.pm
@@ -38,13 +38,13 @@ sub imapd_refresh_ibx { # pi_config->each_inbox cb
}
$ibx->over or return;
$ibx->{over} = undef;
- my $mm = $ibx->mm or return;
- $ibx->{mm} = undef;
# RFC 3501 2.3.1.1 - "A good UIDVALIDITY value to use in
# this case is a 32-bit representation of the creation
# date/time of the mailbox"
- defined($ibx->{uidvalidity} = $mm->created_at) or return;
+ eval { $ibx->uidvalidity };
+ my $mm = delete($ibx->{mm}) or return;
+ defined($ibx->{uidvalidity}) or return;
PublicInbox::IMAP::ensure_slices_exist($imapd, $ibx, $mm->max // 0);
# preload to avoid fragmentation:
diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index b0894a7d..cbb95b8d 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -428,4 +428,6 @@ sub on_unlock {
}
}
+sub uidvalidity { $_[0]->{uidvalidity} //= $_[0]->mm->created_at }
+
1;
^ permalink raw reply related [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-10-16 6:59 6% [PATCH 01/64] inbox: add uidvalidity method Eric Wong
2020-10-16 7:03 7% ` Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).