* [PATCH] import: fix handling of init.defaultBranch
@ 2024-03-10 21:41 14% ` Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2024-03-10 21:41 UTC (permalink / raw)
To: Rob Herring; +Cc: meta
Eric Wong <e@80x24.org> wrote:
> Will try to fix ASAP but offline problems persist :<
Fortunately it turned out to be a simple fix :x
-------8<-------
Subject: [PATCH] import: fix handling of init.defaultBranch
We must chomp the newline in the branch name if it's set.
Reported-by: Rob Herring <robh@kernel.org>
Link: https://public-inbox.org/meta/CAL_JsqK7P4gjLPyvzxNEcYmxT4j6Ah5f3Pz1RqDHxmysTg3aEg@mail.gmail.com/
Fixes: 73830410e4336b77 (treewide: use run_qx where appropriate, 2023-10-27)
---
lib/PublicInbox/Import.pm | 1 +
t/clone-coderepo.t | 8 +++++---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm
index a951874b..ed34d548 100644
--- a/lib/PublicInbox/Import.pm
+++ b/lib/PublicInbox/Import.pm
@@ -26,6 +26,7 @@ sub default_branch () {
state $default_branch = do {
my $h = run_qx([qw(git config --global init.defaultBranch)],
{ GIT_CONFIG => undef });
+ chomp $h;
$h eq '' ? 'refs/heads/master' : "refs/heads/$h";
}
}
diff --git a/t/clone-coderepo.t b/t/clone-coderepo.t
index c0951941..c6180fc4 100644
--- a/t/clone-coderepo.t
+++ b/t/clone-coderepo.t
@@ -7,6 +7,7 @@ use PublicInbox::Import;
use File::Temp;
use File::Path qw(remove_tree);
use PublicInbox::SHA qw(sha1_hex);
+use PublicInbox::IO;
require_mods(qw(json Plack::Builder HTTP::Date HTTP::Status));
require_git_http_backend;
require_git '1.8.5';
@@ -38,9 +39,10 @@ my $t0 = time - 1;
my $m; # manifest hashref
{
- my $rdr = {};
- my $fi_data = './t/git.fast-import-data';
- open $rdr->{0}, '<', $fi_data or xbail "open($fi_data): $!";
+ my $fi_data = PublicInbox::IO::try_cat './t/git.fast-import-data';
+ my $db = PublicInbox::Import::default_branch;
+ $fi_data =~ s!\brefs/heads/master\b!$db!gs;
+ my $rdr = { 0 => \$fi_data };
my @git = ('git', "--git-dir=$pa");
xsys_e([@git, qw(fast-import --quiet)], undef, $rdr);
xsys_e([qw(/bin/cp -Rp a.git b.git)], undef, { -C => "$tmpdir/src" });
^ permalink raw reply related [relevance 14%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2024-03-06 15:44 crash on git-fast-import Rob Herring
2024-03-08 3:20 ` Eric Wong
2024-03-08 14:38 ` Rob Herring
2024-03-10 21:15 ` Eric Wong
2024-03-10 21:41 14% ` [PATCH] import: fix handling of init.defaultBranch Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).