user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH 2/2] import: croak (instead of die) on write failures
  2024-03-08 21:05  5% [PATCH 0/2] fixes noticed while tracking down fast-import failures Eric Wong
@ 2024-03-08 21:05  7% ` Eric Wong
  0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2024-03-08 21:05 UTC (permalink / raw)
  To: meta

This allows accurate reporting of the error location and can be
made to dump a Perl backtrace via PERL5OPT='-MCarp=verbose'.
Noticed while tracking down fast-import failures.

Link: https://public-inbox.org/meta/CAL_JsqK7P4gjLPyvzxNEcYmxT4j6Ah5f3Pz1RqDHxmysTg3aEg@mail.gmail.com/
---
 lib/PublicInbox/Import.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm
index 51ddfa7f..a951874b 100644
--- a/lib/PublicInbox/Import.pm
+++ b/lib/PublicInbox/Import.pm
@@ -85,7 +85,7 @@ sub gfi_start {
 	$self->{io};
 }
 
-sub wfail () { die "write to fast-import failed: $!" }
+sub wfail () { croak "write to fast-import failed: $!" }
 
 sub now_raw () { time . ' +0000' }
 

^ permalink raw reply related	[relevance 7%]

* [PATCH 0/2] fixes noticed while tracking down fast-import failures
@ 2024-03-08 21:05  5% Eric Wong
  2024-03-08 21:05  7% ` [PATCH 2/2] import: croak (instead of die) on write failures Eric Wong
  0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2024-03-08 21:05 UTC (permalink / raw)
  To: meta

I'm still trying to track down the cause of fast-import
failures[1], but this series presents some useful fixes
regardless.

Link: https://public-inbox.org/meta/CAL_JsqK7P4gjLPyvzxNEcYmxT4j6Ah5f3Pz1RqDHxmysTg3aEg@mail.gmail.com/

Eric Wong (2):
  lei: prevent empty {bytes} field in saved search
  import: croak (instead of die) on write failures

 lib/PublicInbox/Import.pm    | 2 +-
 lib/PublicInbox/LeiSearch.pm | 2 ++
 lib/PublicInbox/LeiToMail.pm | 1 +
 lib/PublicInbox/OverIdx.pm   | 6 +++++-
 4 files changed, 9 insertions(+), 2 deletions(-)

^ permalink raw reply	[relevance 5%]

Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2024-03-08 21:05  5% [PATCH 0/2] fixes noticed while tracking down fast-import failures Eric Wong
2024-03-08 21:05  7% ` [PATCH 2/2] import: croak (instead of die) on write failures Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).