* [PATCH 2/3] imaptracker: update_last: simplify callers
2020-08-28 10:12 7% [PATCH 0/3] more watch-related stuff Eric Wong
@ 2020-08-28 10:12 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-08-28 10:12 UTC (permalink / raw)
To: meta
By making it a no-op if last_uid is not defined. This isn't a
hot code path, so the extra method dispatch isn't an issue.
It'll save some indentation/wrapping in future commits.
---
lib/PublicInbox/IMAPTracker.pm | 5 +++--
lib/PublicInbox/WatchMaildir.pm | 4 ++--
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/lib/PublicInbox/IMAPTracker.pm b/lib/PublicInbox/IMAPTracker.pm
index 92f21584..be9caf76 100644
--- a/lib/PublicInbox/IMAPTracker.pm
+++ b/lib/PublicInbox/IMAPTracker.pm
@@ -49,13 +49,14 @@ SELECT uid_validity, uid FROM imap_last WHERE url = ?
}
sub update_last ($$$) {
- my ($self, $validity, $last) = @_;
+ my ($self, $validity, $last_uid) = @_;
+ return unless defined $last_uid;
my $sth = $self->{dbh}->prepare_cached(<<'');
INSERT OR REPLACE INTO imap_last (url, uid_validity, uid)
VALUES (?, ?, ?)
$self->lock_acquire;
- my $rv = $sth->execute($self->{url}, $validity, $last);
+ my $rv = $sth->execute($self->{url}, $validity, $last_uid);
$self->lock_release;
$rv;
}
diff --git a/lib/PublicInbox/WatchMaildir.pm b/lib/PublicInbox/WatchMaildir.pm
index 78aec8a2..a227a6fd 100644
--- a/lib/PublicInbox/WatchMaildir.pm
+++ b/lib/PublicInbox/WatchMaildir.pm
@@ -494,7 +494,7 @@ sub imap_fetch_all ($$$) {
last if $self->{quit};
}
_done_for_now($self);
- $itrk->update_last($r_uidval, $last_uid) if defined $last_uid;
+ $itrk->update_last($r_uidval, $last_uid);
} until ($err || $self->{quit});
$err;
}
@@ -919,7 +919,7 @@ sub nntp_fetch_all ($$$) {
$last_art = $art;
}
_done_for_now($self);
- $itrk->update_last(0, $last_art) if defined $last_art;
+ $itrk->update_last(0, $last_art);
$err;
}
^ permalink raw reply related [relevance 7%]
* [PATCH 0/3] more watch-related stuff
@ 2020-08-28 10:12 7% Eric Wong
2020-08-28 10:12 7% ` [PATCH 2/3] imaptracker: update_last: simplify callers Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-08-28 10:12 UTC (permalink / raw)
To: meta
1/3 is the most important; more watch tweaks coming...
Eric Wong (3):
watch: flush changes to inbox before updating IMAPTracker
imaptracker: update_last: simplify callers
tests: check-run: show skipped tests
lib/PublicInbox/IMAPTracker.pm | 5 +++--
lib/PublicInbox/WatchMaildir.pm | 4 ++--
t/run.perl | 22 ++++++++++++++++++++--
3 files changed, 25 insertions(+), 6 deletions(-)
^ permalink raw reply [relevance 7%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-08-28 10:12 7% [PATCH 0/3] more watch-related stuff Eric Wong
2020-08-28 10:12 7% ` [PATCH 2/3] imaptracker: update_last: simplify callers Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).