user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH 1/2] imap: remove unused args_ok sub
  2022-05-13  0:40  6% [PATCH 0/2] imapd: minor cleanups Eric Wong
@ 2022-05-13  0:40  7% ` Eric Wong
  0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2022-05-13  0:40 UTC (permalink / raw)
  To: meta

Noticed while reviewing pieces for POP3.
---
 lib/PublicInbox/IMAP.pm | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/lib/PublicInbox/IMAP.pm b/lib/PublicInbox/IMAP.pm
index 58a0a9e3..d47e4c2f 100644
--- a/lib/PublicInbox/IMAP.pm
+++ b/lib/PublicInbox/IMAP.pm
@@ -1,4 +1,4 @@
-# Copyright (C) 2020-2021 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 #
 # Each instance of this represents an IMAP client connected to
@@ -1153,15 +1153,6 @@ sub cmd_search ($$$;) {
 	search_common($self, $tag, $query, 1);
 }
 
-sub args_ok ($$) { # duplicated from PublicInbox::NNTP
-	my ($cb, $argc) = @_;
-	my $tot = prototype $cb;
-	my ($nreq, undef) = split(';', $tot);
-	$nreq = ($nreq =~ tr/$//) - 1;
-	$tot = ($tot =~ tr/$//) - 1;
-	($argc <= $tot && $argc >= $nreq);
-}
-
 # returns 1 if we can continue, 0 if not due to buffered writes or disconnect
 sub process_line ($$) {
 	my ($self, $l) = @_;

^ permalink raw reply related	[relevance 7%]

* [PATCH 0/2] imapd: minor cleanups
@ 2022-05-13  0:40  6% Eric Wong
  2022-05-13  0:40  7% ` [PATCH 1/2] imap: remove unused args_ok sub Eric Wong
  0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2022-05-13  0:40 UTC (permalink / raw)
  To: meta

Stuff noticed while working on supporting POP3...

Eric Wong (2):
  imap: remove unused args_ok sub
  imapd: update comment for PublicInbox::ConfigIter

 lib/PublicInbox/IMAP.pm  | 11 +----------
 lib/PublicInbox/IMAPD.pm |  2 +-
 2 files changed, 2 insertions(+), 11 deletions(-)

^ permalink raw reply	[relevance 6%]

Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2022-05-13  0:40  6% [PATCH 0/2] imapd: minor cleanups Eric Wong
2022-05-13  0:40  7% ` [PATCH 1/2] imap: remove unused args_ok sub Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).