* [PATCH 03/10] hval: get rid of unused parameter for new_msgid
2016-07-06 7:14 6% [PATCH 0/10] various misc fixes and updates Eric Wong
@ 2016-07-06 7:14 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-07-06 7:14 UTC (permalink / raw)
To: meta
Exposing compressed Message-IDs in URLs was a mistake,
remove a remnant of it.
---
lib/PublicInbox/ExtMsg.pm | 2 +-
lib/PublicInbox/Hval.pm | 2 +-
lib/PublicInbox/View.pm | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/PublicInbox/ExtMsg.pm b/lib/PublicInbox/ExtMsg.pm
index 73bd4b1..62381e9 100644
--- a/lib/PublicInbox/ExtMsg.pm
+++ b/lib/PublicInbox/ExtMsg.pm
@@ -99,7 +99,7 @@ again:
}
my $code = 404;
- my $h = PublicInbox::Hval->new_msgid($mid, 1);
+ my $h = PublicInbox::Hval->new_msgid($mid);
my $href = $h->as_href;
my $html = $h->as_html;
my $title = "Message-ID <$html> not found";
diff --git a/lib/PublicInbox/Hval.pm b/lib/PublicInbox/Hval.pm
index 9ba7809..652aef3 100644
--- a/lib/PublicInbox/Hval.pm
+++ b/lib/PublicInbox/Hval.pm
@@ -31,7 +31,7 @@ sub new {
}
sub new_msgid {
- my ($class, $msgid, $no_compress) = @_;
+ my ($class, $msgid) = @_;
$msgid = mid_clean($msgid);
$class->new($msgid, $msgid);
}
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index e8395ae..dc6096f 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -551,7 +551,7 @@ sub _parent_headers {
my $irt = in_reply_to($hdr);
if (defined $irt) {
- my $v = PublicInbox::Hval->new_msgid($irt, 1);
+ my $v = PublicInbox::Hval->new_msgid($irt);
my $html = $v->as_html;
my $href = $v->as_href;
$rv .= "In-Reply-To: <";
@@ -661,7 +661,7 @@ sub html_footer {
}
sub linkify_ref_nosrch {
- my $v = PublicInbox::Hval->new_msgid($_[0], 1);
+ my $v = PublicInbox::Hval->new_msgid($_[0]);
my $html = $v->as_html;
my $href = $v->as_href;
"<<a\nhref=\"../$href/\">$html</a>>";
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/10] various misc fixes and updates
@ 2016-07-06 7:14 6% Eric Wong
2016-07-06 7:14 7% ` [PATCH 03/10] hval: get rid of unused parameter for new_msgid Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-07-06 7:14 UTC (permalink / raw)
To: meta
Close to a milestone with HTML UI consistency!
Eric Wong (10):
scripts/dc-dlvr: ensure temporary files are removed
daemon: disable USR2/TTIN/TTOU/WINCH in workers
hval: get rid of unused parameter for new_msgid
address: attempt to handle comments somewhat
wwwstream: allow undef noop callback
extmsg: disable automatic inbox switching
extmsg: switch to wwwstream for partial match, too
view: fix double-escaping of ghost links
www: use HTML <hr> instead of XHTML <hr />
feed: fix links to attachments in Atom feed
lib/PublicInbox/Address.pm | 6 ++--
lib/PublicInbox/Daemon.pm | 3 +-
lib/PublicInbox/ExtMsg.pm | 73 +++++++++++++++++++++++++++---------------
lib/PublicInbox/Feed.pm | 6 ++--
lib/PublicInbox/Hval.pm | 2 +-
lib/PublicInbox/SearchView.pm | 6 ++--
lib/PublicInbox/Unsubscribe.pm | 2 +-
lib/PublicInbox/View.pm | 17 +++++-----
lib/PublicInbox/WwwStream.pm | 6 ++--
scripts/dc-dlvr | 3 +-
t/address.t | 9 ++++++
11 files changed, 84 insertions(+), 49 deletions(-)
--
EW
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-07-06 7:14 6% [PATCH 0/10] various misc fixes and updates Eric Wong
2016-07-06 7:14 7% ` [PATCH 03/10] hval: get rid of unused parameter for new_msgid Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).