user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH 1/3] httpd: document pi-httpd.async as totally unstable
  2016-03-01  8:31  5% [PATCH 0/3] minor httpd related tweaks Eric Wong
@ 2016-03-01  8:31  7% ` Eric Wong
  0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-03-01  8:31 UTC (permalink / raw)
  To: meta

We'll have to use it some more before deciding it is a public
interface.  I do hope for it to be a usable public interface
one day for other users.
---
 lib/PublicInbox/GitHTTPBackend.pm | 2 +-
 script/public-inbox-httpd         | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm
index 56bf24f..c84eefc 100644
--- a/lib/PublicInbox/GitHTTPBackend.pm
+++ b/lib/PublicInbox/GitHTTPBackend.pm
@@ -224,7 +224,7 @@ sub serve_smart {
 	if (my $async = $env->{'pi-httpd.async'}) {
 		$rpipe = $async->($rpipe, $cb);
 		sub { ($res) = @_ } # let Danga::Socket handle the rest.
-	} else { # synchronous loop
+	} else { # synchronous loop for other PSGI servers
 		$vin = '';
 		vec($vin, fileno($rpipe), 1) = 1;
 		sub {
diff --git a/script/public-inbox-httpd b/script/public-inbox-httpd
index f1a5d79..d407059 100755
--- a/script/public-inbox-httpd
+++ b/script/public-inbox-httpd
@@ -59,6 +59,10 @@ daemon_run('0.0.0.0:8080', $refresh,
 
 1;
 
+# XXX This is a totally unstable API for public-inbox internal use only
+# This is exposed via the 'pi-httpd.async' key in the PSGI env hash.
+# The name of this key is not even stable!
+# Currently is is intended for use with read-only pipes.
 package PublicInbox::HTTPD::Async;
 use strict;
 use warnings;
-- 
EW


^ permalink raw reply related	[relevance 7%]

* [PATCH 0/3] minor httpd related tweaks
@ 2016-03-01  8:31  5% Eric Wong
  2016-03-01  8:31  7% ` [PATCH 1/3] httpd: document pi-httpd.async as totally unstable Eric Wong
  0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-03-01  8:31 UTC (permalink / raw)
  To: meta

Fun times ahead :>

Eric Wong (3):
      httpd: document pi-httpd.async as totally unstable
      httpd: remove unneeded err and out fields from class
      http: better error handling for EMFILE/ENFILE

 lib/PublicInbox/GitHTTPBackend.pm |  2 +-
 lib/PublicInbox/HTTP.pm           | 16 +++++++++++++---
 script/public-inbox-httpd         |  6 ++++--
 3 files changed, 18 insertions(+), 6 deletions(-)

^ permalink raw reply	[relevance 5%]

Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-03-01  8:31  5% [PATCH 0/3] minor httpd related tweaks Eric Wong
2016-03-01  8:31  7% ` [PATCH 1/3] httpd: document pi-httpd.async as totally unstable Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).