* [PATCH 1/3] httpd: allow running if ReverseProxy is missing
@ 2016-02-28 5:42 7% Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2016-02-28 5:42 UTC (permalink / raw)
To: meta
Not everybody will be running this behind a ReverseProxy;
but it's probably the likely configuration. Anyways,
warn about this and also about Deflater being missing.
---
examples/public-inbox.psgi | 20 +++++++++++++-------
script/public-inbox-httpd | 24 +++++++++++++++---------
2 files changed, 28 insertions(+), 16 deletions(-)
diff --git a/examples/public-inbox.psgi b/examples/public-inbox.psgi
index acceba3..0d11c19 100644
--- a/examples/public-inbox.psgi
+++ b/examples/public-inbox.psgi
@@ -9,21 +9,27 @@ use PublicInbox::WWW;
PublicInbox::WWW->preload;
use Plack::Request;
use Plack::Builder;
-my $have_deflater = eval { require Plack::Middleware::Deflater; 1 };
my $www = PublicInbox::WWW->new;
builder {
enable 'Chunked';
- if ($have_deflater) {
+ eval {
enable 'Deflater',
- content_type => [ 'text/html', 'text/plain',
- 'application/atom+xml' ];
- }
-
+ content_type => [ qw(
+ text/html
+ text/plain
+ application/atom+xml
+ )]
+ };
+ $@ and warn
+"Plack::Middleware::Deflater missing, bandwidth will be wasted\n";
# Enable to ensure redirects and Atom feed URLs are generated
# properly when running behind a reverse proxy server which
# sets X-Forwarded-For and X-Forwarded-Proto request headers.
# See Plack::Middleware::ReverseProxy documentation for details
- enable 'ReverseProxy';
+ eval { enable 'ReverseProxy' };
+ $@ and warn
+"Plack::Middleware::ReverseProxy missing,\n",
+"URL generation for redirects may be wrong if behind a reverse proxy\n";
enable 'Head';
sub { $www->call(@_) };
diff --git a/script/public-inbox-httpd b/script/public-inbox-httpd
index 6109af0..19315bb 100755
--- a/script/public-inbox-httpd
+++ b/script/public-inbox-httpd
@@ -24,18 +24,24 @@ my $refresh = sub {
PublicInbox::WWW->preload;
my $www = PublicInbox::WWW->new;
$app = eval {
- my $deflate_types = eval {
- require Plack::Middleware::Deflater;
- [ 'text/html', 'text/plain',
- 'application/atom+xml' ]
- };
builder {
enable 'Chunked';
- if ($deflate_types) {
+ eval {
enable 'Deflater',
- content_type => $deflate_types
- }
- enable 'ReverseProxy';
+ content_type => [ qw(
+ text/html
+ text/plain
+ application/atom+xml
+ )]
+ };
+ $@ and warn
+"Plack::Middleware::Deflater missing, bandwidth will be wasted\n";
+
+ eval { enable 'ReverseProxy' };
+ $@ and warn
+"Plack::Middleware::ReverseProxy missing,\n",
+"URL generation for redirects may be wrong if behind a reverse proxy\n";
+
enable 'Head';
sub { $www->call(@_) };
};
--
EW
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-02-28 5:42 7% [PATCH 1/3] httpd: allow running if ReverseProxy is missing Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).