* [PATCH 2/3] httpd: (cleanup) use reference instead of *glob
2019-07-08 7:39 5% [PATCH 0/3] a few minor cleanups Eric Wong
@ 2019-07-08 7:39 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2019-07-08 7:39 UTC (permalink / raw)
To: meta
*glob notation isn't always necessary, and there's
no need to disable 'once' warnings, this way.
---
lib/PublicInbox/HTTPD.pm | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/lib/PublicInbox/HTTPD.pm b/lib/PublicInbox/HTTPD.pm
index b0bf94ad..d10ec51c 100644
--- a/lib/PublicInbox/HTTPD.pm
+++ b/lib/PublicInbox/HTTPD.pm
@@ -39,10 +39,7 @@ sub new {
# The rest of our PSGI code is generic, relying
# on "pull" model using "getline" to prevent
# over-buffering.
- 'pi-httpd.async' => do {
- no warnings 'once';
- *pi_httpd_async
- },
+ 'pi-httpd.async' => \&pi_httpd_async
);
bless {
app => $app,
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/3] a few minor cleanups
@ 2019-07-08 7:39 5% Eric Wong
2019-07-08 7:39 7% ` [PATCH 2/3] httpd: (cleanup) use reference instead of *glob Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2019-07-08 7:39 UTC (permalink / raw)
To: meta
Just some minor things to make the code more pleasant
and less error-prone.
Eric Wong (3):
daemon: use POSIX and WNOHANG more idiomatically
httpd: (cleanup) use reference instead of *glob
http|nntp: "use PublicInbox::DS" instead of ->import
lib/PublicInbox/Daemon.pm | 4 ++--
lib/PublicInbox/HTTP.pm | 2 +-
lib/PublicInbox/HTTPD.pm | 5 +----
lib/PublicInbox/NNTP.pm | 2 +-
4 files changed, 5 insertions(+), 8 deletions(-)
--
EW
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-07-08 7:39 5% [PATCH 0/3] a few minor cleanups Eric Wong
2019-07-08 7:39 7% ` [PATCH 2/3] httpd: (cleanup) use reference instead of *glob Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).