* [PATCH 2/7] http: clarify comments about layering violation
2016-05-28 1:57 6% [PATCH 0/7] miscellaneous cleanups Eric Wong
@ 2016-05-28 1:57 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-05-28 1:57 UTC (permalink / raw)
To: meta
It's a low priority, but acknowledge it.
---
lib/PublicInbox/HTTP.pm | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm
index 0454f60..fcbd758 100644
--- a/lib/PublicInbox/HTTP.pm
+++ b/lib/PublicInbox/HTTP.pm
@@ -4,7 +4,7 @@
# Generic PSGI server for convenience. It aims to provide
# a consistent experience for public-inbox admins so they don't have
# to learn different ways to admin both NNTP and HTTP components.
-# There's nothing public-inbox-specific, here.
+# There's nothing which depends on public-inbox, here.
# Each instance of this class represents a HTTP client socket
package PublicInbox::HTTP;
@@ -25,7 +25,7 @@ use constant {
CHUNK_MAX_HDR => 256,
};
-# FIXME: duplicated code with NNTP.pm
+# FIXME: duplicated code with NNTP.pm, layering violation
my $WEAKEN = {}; # string(inbox) -> inbox
my $weakt;
sub weaken_task () {
@@ -249,6 +249,8 @@ sub response_done ($$) {
$self->{env} = undef;
$self->write("0\r\n\r\n") if $alive == 2;
$self->write(sub { $alive ? next_request($self) : $self->close });
+
+ # FIXME: layering violation
if (my $obj = $env->{'pi-httpd.inbox'}) {
# grace period for reaping resources
$WEAKEN->{"$obj"} = $obj;
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/7] miscellaneous cleanups
@ 2016-05-28 1:57 6% Eric Wong
2016-05-28 1:57 7% ` [PATCH 2/7] http: clarify comments about layering violation Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-05-28 1:57 UTC (permalink / raw)
To: meta
Only the last one (NewsGroup class removal for ::Inbox) is
likely to cause problems but I'll be checking logs for
errors.
Eric Wong (7):
t/plack: ensure we can cascade on common endpoints
http: clarify comments about layering violation
Makefile.PL: allow N to be overridden
examples: config no longer supports atomUrl
www: remove footer_html support
config: remove try_cat
remove redundant NewsGroup class
MANIFEST | 1 -
Makefile.PL | 2 +-
examples/public-inbox-config | 1 -
lib/PublicInbox/Config.pm | 49 +++++++++++++++-----------
lib/PublicInbox/HTTP.pm | 6 ++--
lib/PublicInbox/Inbox.pm | 17 ++++-----
lib/PublicInbox/NNTP.pm | 9 ++---
lib/PublicInbox/NNTPD.pm | 27 ++++----------
lib/PublicInbox/NewsGroup.pm | 84 --------------------------------------------
lib/PublicInbox/NewsWWW.pm | 38 ++------------------
lib/PublicInbox/WWW.pm | 6 ++--
t/config.t | 2 ++
t/nntp.t | 15 +++++---
t/nntpd.t | 4 ++-
t/plack.t | 12 +++++--
15 files changed, 83 insertions(+), 190 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-05-28 1:57 6% [PATCH 0/7] miscellaneous cleanups Eric Wong
2016-05-28 1:57 7% ` [PATCH 2/7] http: clarify comments about layering violation Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).