* [PATCH 3/5] githttpbackend: remove ancient compatibility check
2019-12-31 10:30 5% [PATCH 0/5] some minor cleanups and doc updates Eric Wong
@ 2019-12-31 10:30 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2019-12-31 10:30 UTC (permalink / raw)
To: meta
The ref() call could be hitting memory leaks on Perl 5.16.x.
It's been 3 years (2016-12-25) since 292ca34140489da2
("githttpbackend: simplify compatibility code") back when
this project was barely known and probably nobody used
examples/public-inbox.psgi...
---
lib/PublicInbox/GitHTTPBackend.pm | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm
index 8dd27a75..8883ec34 100644
--- a/lib/PublicInbox/GitHTTPBackend.pm
+++ b/lib/PublicInbox/GitHTTPBackend.pm
@@ -47,9 +47,6 @@ sub r ($;$) {
sub serve {
my ($env, $git, $path) = @_;
- # XXX compatibility... ugh, can we stop supporting this?
- $git = PublicInbox::Git->new($git) unless ref($git);
-
# Documentation/technical/http-protocol.txt in git.git
# requires one and exactly one query parameter:
if ($env->{QUERY_STRING} =~ /\Aservice=git-[A-Za-z0-9_]+-pack\z/ ||
^ permalink raw reply related [relevance 7%]
* [PATCH 0/5] some minor cleanups and doc updates
@ 2019-12-31 10:30 5% Eric Wong
2019-12-31 10:30 7% ` [PATCH 3/5] githttpbackend: remove ancient compatibility check Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2019-12-31 10:30 UTC (permalink / raw)
To: meta
Actual features coming, later, but some cleanups and internal
doc updates I found along the way. I'm a tiny bit worried
about PATCH 3/5 breaking somebody's setup because of old
versions of examples/public-inbox.psgi, but considering how
little adoption this project had in 2016, maybe it's not a
big deal...
Eric Wong (5):
wwwstatic: getline: die on missing psgix.io
http: update comment about psgix.io usage
githttpbackend: remove ancient compatibility check
filter/base: export REJECT as a constant
cgit: type declaration for PublicInbox::Git
lib/PublicInbox/Cgit.pm | 3 ++-
lib/PublicInbox/Filter/Base.pm | 2 ++
lib/PublicInbox/GitHTTPBackend.pm | 3 ---
lib/PublicInbox/HTTP.pm | 2 +-
lib/PublicInbox/InboxWritable.pm | 3 +--
lib/PublicInbox/WatchMaildir.pm | 3 +--
lib/PublicInbox/WwwStatic.pm | 20 +++++++++-----------
script/public-inbox-purge | 4 +---
8 files changed, 17 insertions(+), 23 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-12-31 10:30 5% [PATCH 0/5] some minor cleanups and doc updates Eric Wong
2019-12-31 10:30 7% ` [PATCH 3/5] githttpbackend: remove ancient compatibility check Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).