user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH 4/5] git: quiet down `rev-parse --git-path' errors
  2023-12-15 20:22  5% [PATCH 0/5] old git and Test::More fixes Eric Wong
@ 2023-12-15 20:22  7% ` Eric Wong
  0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2023-12-15 20:22 UTC (permalink / raw)
  To: meta

This fixes t/mda.t with git 1.8.5
---
 lib/PublicInbox/Git.pm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index 9c4d938e..6c4fcf93 100644
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -107,7 +107,9 @@ sub git_path ($$) {
 			$d;
 		} else {
 			local $/ = "\n";
-			my $s = $self->qx(qw(rev-parse --git-path), $path);
+			my $rdr = { 2 => \my $err };
+			my $s = $self->qx([qw(rev-parse --git-path), $path],
+					undef, $rdr);
 			chomp $s;
 
 			# git prior to 2.5.0 did not understand --git-path

^ permalink raw reply related	[relevance 7%]

* [PATCH 0/5] old git and Test::More fixes
@ 2023-12-15 20:22  5% Eric Wong
  2023-12-15 20:22  7% ` [PATCH 4/5] git: quiet down `rev-parse --git-path' errors Eric Wong
  0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2023-12-15 20:22 UTC (permalink / raw)
  To: meta

This makes the experience nicer for people using CentOS 7.x
out-of-the-box (without 3rd-party repos).

Eric Wong (5):
  tests: quiet uninitialized warnings on CentOS 7.x
  searchidx: quiet down old git patchid
  cindex: --prune needs git 2.6+
  git: quiet down `rev-parse --git-path' errors
  t/pop3d-limit: use v1 inbox to test on ancient git

 lib/PublicInbox/CodeSearchIdx.pm |  2 ++
 lib/PublicInbox/Git.pm           |  4 +++-
 lib/PublicInbox/SearchIdx.pm     | 12 ++++++++++--
 lib/PublicInbox/TestCommon.pm    | 20 ++++++++++----------
 t/cindex.t                       |  1 +
 t/cmd_ipc.t                      |  4 ++--
 t/ds-poll.t                      |  2 +-
 t/httpd-corner.t                 |  2 +-
 t/lei-convert.t                  |  2 +-
 t/lei-daemon.t                   |  2 +-
 t/lei-sigpipe.t                  |  2 +-
 t/pop3d-limit.t                  |  2 +-
 12 files changed, 34 insertions(+), 21 deletions(-)

^ permalink raw reply	[relevance 5%]

Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2023-12-15 20:22  5% [PATCH 0/5] old git and Test::More fixes Eric Wong
2023-12-15 20:22  7% ` [PATCH 4/5] git: quiet down `rev-parse --git-path' errors Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).