* [PATCH] filter: remove out dated comments
2016-04-09 1:15 7% [PATCH] filter: preserve Mail-Followup-To and Mail-Reply-To Eric Wong
@ 2016-04-09 1:23 5% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-04-09 1:23 UTC (permalink / raw)
To: meta
Followup-to commit 5a590bcb6813
("filter: preserve Mail-Followup-To and Mail-Reply-To")
---
lib/PublicInbox/Filter.pm | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/PublicInbox/Filter.pm b/lib/PublicInbox/Filter.pm
index 4fdbe87..10173ad 100644
--- a/lib/PublicInbox/Filter.pm
+++ b/lib/PublicInbox/Filter.pm
@@ -31,8 +31,6 @@ sub run {
# kill potentially bad/confusing headers
# Note: ssoma already does this, but since we mangle the message,
# we should do this before it gets to ssoma.
- # We also kill Mail-{Followup,Reply}-To headers due to
- # the nature of public-inbox having no real subscribers.
foreach my $d (qw(status lines content-length)) {
$mime->header_set($d);
}
--
EW
^ permalink raw reply related [relevance 5%]
* [PATCH] filter: preserve Mail-Followup-To and Mail-Reply-To
@ 2016-04-09 1:15 7% Eric Wong
2016-04-09 1:23 5% ` [PATCH] filter: remove out dated comments Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-04-09 1:15 UTC (permalink / raw)
To: meta
Allow users to do wacky things here if they really wish...
It's bad practice, but at least allow other readers to
mock users of these headers :P
---
lib/PublicInbox/Filter.pm | 3 +--
t/filter.t | 18 ------------------
2 files changed, 1 insertion(+), 20 deletions(-)
diff --git a/lib/PublicInbox/Filter.pm b/lib/PublicInbox/Filter.pm
index ea6fd33..4fdbe87 100644
--- a/lib/PublicInbox/Filter.pm
+++ b/lib/PublicInbox/Filter.pm
@@ -33,8 +33,7 @@ sub run {
# we should do this before it gets to ssoma.
# We also kill Mail-{Followup,Reply}-To headers due to
# the nature of public-inbox having no real subscribers.
- foreach my $d (qw(status lines content-length
- mail-followup-to mail-reply-to)) {
+ foreach my $d (qw(status lines content-length)) {
$mime->header_set($d);
}
diff --git a/t/filter.t b/t/filter.t
index 80a7c12..609a192 100644
--- a/t/filter.t
+++ b/t/filter.t
@@ -297,24 +297,6 @@ sub count_body_parts {
like($s->as_string, qr/scrubbed/, "scrubbed message");
}
-{
- my $s = Email::MIME->create(
- header => [
- From => 'a@example.com',
- To => 'b@example.com',
- 'Content-Type' => 'text/plain',
- 'Mail-Followup-To' => 'c@example.com',
- Subject => 'mfttest',
- ],
- body => "mft\n",
- );
-
- is('c@example.com', $s->header("Mail-Followup-To"),
- "mft set correctly");
- is(1, PublicInbox::Filter->run($s), "run succeeded for mft");
- is(undef, $s->header("Mail-Followup-To"), "mft stripped");
-}
-
# multi-part with application/octet-stream
{
my $os = 'application/octet-stream';
--
EW
^ permalink raw reply related [relevance 7%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-04-09 1:15 7% [PATCH] filter: preserve Mail-Followup-To and Mail-Reply-To Eric Wong
2016-04-09 1:23 5% ` [PATCH] filter: remove out dated comments Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).