* [PATCH 3/6] feed: remove dead code and unneeded use
2016-07-09 3:18 5% [PATCH 0/6] bunch of cleanups and a new feature! Eric Wong
@ 2016-07-09 3:18 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-07-09 3:18 UTC (permalink / raw)
To: meta
We've cleaned up our code in recent days and WwwStream
provides a consistent header for our HTML pages.
---
lib/PublicInbox/Feed.pm | 22 ----------------------
1 file changed, 22 deletions(-)
diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm
index 3b0ae42..a697a43 100644
--- a/lib/PublicInbox/Feed.pm
+++ b/lib/PublicInbox/Feed.pm
@@ -8,7 +8,6 @@ use warnings;
use Email::MIME;
use Date::Parse qw(strptime);
use PublicInbox::Hval qw/ascii_html/;
-use PublicInbox::Git;
use PublicInbox::View;
use PublicInbox::MID qw/mid_clean mid2path/;
use PublicInbox::Address;
@@ -150,27 +149,6 @@ sub emit_atom_thread {
end_feed($fh);
}
-sub _html_index_top {
- my ($feed_opts, $srch) = @_;
-
- my $title = ascii_html($feed_opts->{description} || '');
- my $top = "<b>$title</b> (<a\nhref=\"new.atom\">Atom feed</a>)";
- if ($srch) {
- $top = qq{<form\naction=""><pre>$top} .
- qq{ <input\nname=q\ntype=text />} .
- qq{<input\ntype=submit\nvalue=search />} .
- q{</pre></form><pre>}
- } else {
- $top = '<pre>' . $top . "\n";
- }
-
- "<html><head><title>$title</title>" .
- "<link\nrel=alternate\ntitle=\"Atom feed\"\n".
- "href=\"new.atom\"\ntype=\"application/atom+xml\"/>" .
- PublicInbox::Hval::STYLE .
- "</head><body>$top";
-}
-
sub new_html_footer {
my ($ctx, $last) = @_;
my $qp = delete $ctx->{qp} or return;
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/6] bunch of cleanups and a new feature!
@ 2016-07-09 3:18 5% Eric Wong
2016-07-09 3:18 7% ` [PATCH 3/6] feed: remove dead code and unneeded use Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-07-09 3:18 UTC (permalink / raw)
To: meta
The final patch seems to be what's needed to maintain fairness
for small inboxes while serving large ones.
Eric Wong (6):
www: drop unused constants
www: cleanup parameter passing
feed: remove dead code and unneeded use
cleanup some unnecessary use/requires
qspawn: allow configurable limiters
www: add configurable limiters
MANIFEST | 1 +
lib/PublicInbox/Config.pm | 13 +++++++-
lib/PublicInbox/ExtMsg.pm | 4 +--
lib/PublicInbox/Feed.pm | 23 -------------
lib/PublicInbox/GitHTTPBackend.pm | 15 +++++++--
lib/PublicInbox/Inbox.pm | 25 +++++++++++++-
lib/PublicInbox/Mbox.pm | 1 -
lib/PublicInbox/Qspawn.pm | 39 ++++++++++++++++------
lib/PublicInbox/View.pm | 2 --
lib/PublicInbox/WWW.pm | 70 ++++++++++++++++++---------------------
t/config.t | 2 ++
t/config_limiter.t | 50 ++++++++++++++++++++++++++++
t/qspawn.t | 10 +++---
13 files changed, 171 insertions(+), 84 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-07-09 3:18 5% [PATCH 0/6] bunch of cleanups and a new feature! Eric Wong
2016-07-09 3:18 7% ` [PATCH 3/6] feed: remove dead code and unneeded use Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).