user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH] feed: favor relative URL to Atom feed in HTML
@ 2016-02-13 22:50  7% Eric Wong
  0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2016-02-13 22:50 UTC (permalink / raw)
  To: meta

Normal browsers should understand relative path names.
Atom feeds may be hosted externally and seems to need
full URLs.
---
 lib/PublicInbox/Feed.pm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm
index bbc89f2..a0aa62a 100644
--- a/lib/PublicInbox/Feed.pm
+++ b/lib/PublicInbox/Feed.pm
@@ -121,12 +121,11 @@ sub emit_html_index {
 
 	my $title = $feed_opts->{description} || '';
 	$title = PublicInbox::Hval->new_oneline($title)->as_html;
-	my $atom_url = $feed_opts->{atomurl};
 	my ($footer, $param, $last);
 	my $state = { ctx => $ctx, seen => {}, anchor_idx => 0 };
 	my $srch = $ctx->{srch};
 
-	my $top = "<b>$title</b> (<a\nhref=\"$atom_url\">Atom feed</a>)";
+	my $top = "<b>$title</b> (<a\nhref=\"new.atom\">Atom feed</a>)";
 
 	if ($srch) {
 		$top = qq{<form\naction=""><pre>$top} .
@@ -139,7 +138,7 @@ sub emit_html_index {
 
 	$fh->write("<html><head><title>$title</title>" .
 		   "<link\nrel=alternate\ntitle=\"Atom feed\"\n".
-		   "href=\"$atom_url\"\ntype=\"application/atom+xml\"/>" .
+		   "href=\"new.atom\"\ntype=\"application/atom+xml\"/>" .
 		   PublicInbox::Hval::STYLE .
 		   "</head><body>$top");
 
-- 
EW


^ permalink raw reply related	[relevance 7%]

Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-02-13 22:50  7% [PATCH] feed: favor relative URL to Atom feed in HTML Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).