* [PATCH] feed: drop needless version check
@ 2020-04-23 1:54 7% Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2020-04-23 1:54 UTC (permalink / raw)
To: meta
We don't need to be checking inbox versions in parts of the WWW
code. Checking the presence of $ibx->over is enough, everywhere.
---
lib/PublicInbox/Feed.pm | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm
index 07347c63..4cb295e6 100644
--- a/lib/PublicInbox/Feed.pm
+++ b/lib/PublicInbox/Feed.pm
@@ -84,15 +84,10 @@ sub recent_msgs {
my ($ctx) = @_;
my $ibx = $ctx->{-inbox};
my $max = $ibx->{feedmax};
- my $qp = $ctx->{qp};
- my $v = $ibx->version;
- if ($v > 2) {
- die "BUG: unsupported inbox version: $v\n";
- }
- if ($ibx->over) {
- return PublicInbox::View::paginate_recent($ctx, $max);
- }
+ return PublicInbox::View::paginate_recent($ctx, $max) if $ibx->over;
+ # only for rare v1 inboxes which aren't indexed at all
+ my $qp = $ctx->{qp};
my $hex = '[a-f0-9]';
my $addmsg = qr!^:000000 100644 \S+ (\S+) A\t${hex}{2}/${hex}{38}$!;
my $delmsg = qr!^:100644 000000 (\S+) \S+ D\t(${hex}{2}/${hex}{38})$!;
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-04-23 1:54 7% [PATCH] feed: drop needless version check Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).