* [PATCH 6/7] feed: avoid unnecessary map loop in non-over path
2022-08-04 8:16 6% [PATCH 0/7] various op/allocation golfing Eric Wong
@ 2022-08-04 8:17 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2022-08-04 8:17 UTC (permalink / raw)
To: meta
We can bless objects while doing the initial insertion to avoid
extra the extra map iteration and temporary array(s). Fewer ops
means memory savings for the likely case of ->over users, too.
---
lib/PublicInbox/Feed.pm | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm
index b2219dad..ee579f6d 100644
--- a/lib/PublicInbox/Feed.pm
+++ b/lib/PublicInbox/Feed.pm
@@ -1,10 +1,10 @@
-# Copyright (C) 2013-2021 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
#
# Used for generating Atom feeds for web-accessible mailing list archives.
package PublicInbox::Feed;
use strict;
-use warnings;
+use v5.10.1;
use PublicInbox::View;
use PublicInbox::WwwAtomStream;
use PublicInbox::Smsg; # this loads w/o Search::Xapian
@@ -108,13 +108,13 @@ sub recent_msgs {
my $last;
my $last_commit;
local $/ = "\n";
- my @oids;
+ my @ret;
while (defined(my $line = <$log>)) {
if ($line =~ /$addmsg/o) {
my $add = $1;
next if $deleted{$add}; # optimization-only
- push @oids, $add;
- if (scalar(@oids) >= $max) {
+ push(@ret, bless { blob => $add }, 'PublicInbox::Smsg');
+ if (scalar(@ret) >= $max) {
$last = 1;
last;
}
@@ -136,8 +136,7 @@ sub recent_msgs {
$last_commit and
$ctx->{next_page} = qq[<a\nhref="?r=$last_commit"\nrel=next>] .
'next (older)</a>';
-
- [ map { bless {blob => $_ }, 'PublicInbox::Smsg' } @oids ];
+ \@ret;
}
1;
^ permalink raw reply related [relevance 7%]
* [PATCH 0/7] various op/allocation golfing
@ 2022-08-04 8:16 6% Eric Wong
2022-08-04 8:17 7% ` [PATCH 6/7] feed: avoid unnecessary map loop in non-over path Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2022-08-04 8:16 UTC (permalink / raw)
To: meta
Nothing major, but some of these reduce Perl internal pad space,
which tends to add up across codebases with many cold paths.
Eric Wong (7):
http: coerce SERVER_PORT to integer
over: get_xref3: modify rows in-place
isearch: mset_to_artnums: avoid unnecessary ops
lei_overview: remove pointless map {} op
imap: ensure_slices_exist: drop needless map and array
feed: avoid unnecessary map loop in non-over path
view: avoid intermediate array when streaming thread
lib/PublicInbox/Feed.pm | 13 ++++++-------
lib/PublicInbox/HTTP.pm | 2 +-
lib/PublicInbox/IMAP.pm | 7 ++-----
lib/PublicInbox/Isearch.pm | 5 ++---
lib/PublicInbox/LeiOverview.pm | 2 +-
lib/PublicInbox/Over.pm | 8 ++++----
lib/PublicInbox/View.pm | 4 ++--
7 files changed, 18 insertions(+), 23 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2022-08-04 8:16 6% [PATCH 0/7] various op/allocation golfing Eric Wong
2022-08-04 8:17 7% ` [PATCH 6/7] feed: avoid unnecessary map loop in non-over path Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).